Adjust Espressif wolfssl_echoserver example timehelper #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejohnstown
approved these changes
Jul 23, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Sep 24, 2024
Adjust Espressif wolfssl_echoserver example timehelper
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 18, 2024
Adjust Espressif wolfssl_echoserver example timehelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the Espressif
wolfssl_echoserverbuild error noted in #728 when publishing wolfssh as a Managed Component by updating the example and not the library. The root cause of the problem is the un-gated header timelib functions and the respective type difference:intvsesp_err_t.Eventually the example needs to be revised to completely remove the local timelib and use the esp-sdk-lib.h instead.
For now, since both the local example code and the
esp-sdk-lib.huse the same time-related function names, theesp_err_treturn type updates in this PR for the example allow an interim solution to the build problem.Some of the other warnings observed will need to be addressed in a wolfssl update.
The
REQUIRESCMake value does not needesp_netifdue to theHAS_ESP_NETIF_SNTPgating in the example which is disabled by default.Since the core wolfSSH library remains unchanged, I plan to publish the wolfSSH Espressif Managed Component with this update included on top of the v1.4.18-stable release tag.