add example manual verification of quote signature with ecc #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobBarthelmeh
force-pushed
the
example_quote
branch
from
b0713ed to
a3beae8
Compare
dgarske
requested changes
Sep 17, 2024
dgarske
requested changes
Sep 17, 2024
examples/pcr/quote.c
Outdated
| goto exit; | ||
| } | ||
|
|
||
| pubKey = (byte*)malloc(pubKeySz); |
There was a problem hiding this comment.
Please use XMALLOC/XFREE for portability. They exist unless WOLFTPM2_NO_HEAP is used.
examples/pcr/quote.c
Outdated
| @@ -229,6 +266,60 @@ int TPM2_PCR_Quote_Test(void* userCtx, int argc, char *argv[]) | |||
| cmdOut.quoteResult.signature.signature.rsassa.sig.size); | |||
| #endif | |||
|
|
|||
| #ifdef HAVE_ECC | |||
There was a problem hiding this comment.
Consider also gating on WOLFTPM2_NO_HEAP and WOLFSSL_PUBLIC_MP
| mp_free(&r); | ||
| mp_free(&s); | ||
| wc_ecc_free(&ecKey); | ||
| printf("%s [rc = %d, result = %d]\n", (res == 1)? "SUCCESS": "FAILURE", |
There was a problem hiding this comment.
Mine consistently shows: Attempting to manually verify the quotes signature :FAILURE [rc = 0, result = 0]. Any special steps?
There was a problem hiding this comment.
Possibly different for swtpm used? Try with ms-tpm-20-ref. I made a commit now updating the docs/SWTPM.md with steps for a test done.
|
Yup, can add in RSA. Would like to follow up with it though in a separate PR, keeping this one with as few code changes as can for the use. |
… `examples/pcr/quote.c:336:9: error: use of undeclared identifier 'pubKey'`.
dgarske
approved these changes
Sep 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./examples/pcr/quote -ecc