Improvements/fixes to NV auth and session auth set/unset #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbland1
requested changes
Sep 15, 2023
src/tpm2_wrap.c
Outdated
| devSession = &dev->session[index]; | ||
|
|
||
| /* save off nonce from TPM to support continued use of session */ | ||
| memcpy(&tpmSession->nonceTPM, &devSession->nonceTPM, sizeof(TPM2B_NONCE)); |
* Fix bug with NV name after first write (only appears when using HMAC session). * Add new API `wolfTPM2_UnsetAuthSession` to unset auth index for a session and save off the nonce from the TPM. This allows auth to be unset/set again with the same session. * Cleanup in the NV API's for unsetting of the auth to be handled by caller, not in API.
dgarske
added a commit
to dgarske/wolfBoot
that referenced
this pull request
Sep 15, 2023
… nonce, so the session auth can be properly set again. Requires wolfTPM PR wolfSSL/wolfTPM#299
dgarske
added a commit
to dgarske/wolfBoot
that referenced
this pull request
Sep 15, 2023
… nonce, so the session auth can be properly set again. Requires wolfTPM PR wolfSSL/wolfTPM#299
danielinux
pushed a commit
to wolfSSL/wolfBoot
that referenced
this pull request
Sep 18, 2023
… nonce, so the session auth can be properly set again. Requires wolfTPM PR wolfSSL/wolfTPM#299
dgarske
added a commit
to dgarske/wolfTPM
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfTPM2_UnsetAuthSessionto unset auth index for a session and save off the nonce from the TPM. This allows auth to be unset/set again with the same session.