Add patch that adds support for wolfssl TLS sockets in zephyr #195
Conversation
| @@ -0,0 +1,33 @@ | |||
| ## How to setup wolfSSL support for standard Zephyr TLS Sockets and RNG | |||
There was a problem hiding this comment.
Please update the zephyr/include.am to include these with EXTRA_DIST so they are included with a "make dist"
There was a problem hiding this comment.
So all new files are part of the patch. I dont think the new overlay files should go in EXTRA_DIST as they arent needed, and will not exist, for zephyr users that dont use the patch. Also these new files arent really part of the zephyr wolfssl external module, they are specifically extensions of the zephyr samples so I dont know if it makes sense for extensions of zephyr samples to be in a wolfssl distribution right? Especially since the associated changes in zephyr sockets_tls.c wont necessarily be there, meaning we are then distributing overlays that are dependent on external changes.
There was a problem hiding this comment.
Do you want these files part of the wolfssl download package or the commercial release? In my opinion all files need to be included... Please add to the zephyr/include.am these two new files.
There was a problem hiding this comment.
I can look at trying to do a conditional add but im still not so sure. "Do you want these files part of the wolfssl download package or the commercial release?" I think these changes should be bound to the changes in the zephyr sources. So if those changes to the zephyr sources arent part of the wolfssl download package or commercial release then I believe these should also not be included.
There was a problem hiding this comment.
It doesn't have to be conditional. Always include as EXTRA_DIST+=....
No description provided.