Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 digits variant to 7segment-element #131

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Conversation

DurandA
Copy link
Contributor

@DurandA DurandA commented Jul 10, 2022

As discussed in wokwi/wokwi-features#383, this adds a 3 digits variant to the 7segment part.

I was not able to identify a model that was more popular to others, but most Chinese manufacturers seems to use the same pinout (see LCSC datasheets).

Finally, pin 6 is not connected. I am not sure what is the convention for Wokwi in this case.

@urish urish merged commit 88b14e8 into wokwi:master Jul 10, 2022
@urish
Copy link
Collaborator

urish commented Jul 10, 2022

Thanks! Your change is now in production :)

Finally, pin 6 is not connected. I am not sure what is the convention for Wokwi in this case.

Most often, we just add this pin and call it "NC", "NC2", etc. (usually this is how the pins are denoted in the pinout, and we try to keep the names consistent in the pinout). But omitting the pin (like you did) also makes sense to me - no strong opinion which way is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants