Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the default props #715

Closed
wants to merge 1 commit into from
Closed

Expose the default props #715

wants to merge 1 commit into from

Conversation

mrfullset
Copy link

#706

I've exposed shared folder which contains default definitions of format*. Unfortunately, I wasn't able to find default implementation for navigationLabel function.

@wojtekmaj
Copy link
Owner

I'm sorry, but it's a no from me. The reason is that this vastly expands the amount of "public" code that, when changed, would potentially create a breaking change and I would need to be much, much more careful about what I'm doing in these files. Moreover, without proper documentation, you're still pretty much on your own, so this change alone doesn't provide much value.

However, I'll consider moving certain parts of this code to a separate, public, documented package that I would be able to use in my packages, including React-Calendar - and so would you! Is that something that you would be happy with?

@wojtekmaj wojtekmaj closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants