Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always pull versions from metadata #782

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

henryiii
Copy link
Collaborator

Close #779. A random attribute can move around, but we can always ask for the metadata version.

@chrysle
Copy link
Contributor

chrysle commented Feb 24, 2024

Have you already considered adding a compat module?

@henryiii
Copy link
Collaborator Author

Of course. https://learn.scientific-python.org/development/patterns/backports/

I’ll probably do that in the future.

@henryiii henryiii merged commit 55e09cd into wntrblm:main Feb 24, 2024
22 checks passed
@henryiii henryiii deleted the henryiii/fix/metadataversion branch February 24, 2024 15:08
@henryiii
Copy link
Collaborator Author

@chrysle though, since I expect to see if we are okay dropping 3.7 after the next release, and basically every comparison I see is based on < 3.8, it might not be worth adding a compat module. I'll probably wait to see after next release.

@chrysle
Copy link
Contributor

chrysle commented Feb 24, 2024

I'll probably wait to see after next release.

Sounds good. If you need some help, I'm available for hire ;-)

https://learn.scientific-python.org/development/patterns/backports/

Good article, by the way.

@edgarrmondragon
Copy link
Contributor

fwiw there's still ~23% of Nox downloads on 3.7, though I guess users could just use an older Nox if they're stuck on an EOL Python

a87b0a8e-22a4-4cb6-bd3e-d7e2bd423c5f.png

(Disregard the August downloads, they're incomplete)

@henryiii
Copy link
Collaborator Author

though I guess users could just use an older Nox if they're stuck on an EOL Python

Yep. Though that’s why I’d like to get this release out supporting 3.7, since we have already put the effort in. In general, it’s not always helpful to keep supporting EoL Pythons, as you can easily break something that would have worked if you just dropped the older Python. But the last release should be a good one. :)

github-actions bot pushed a commit to msclock/sphinx-deployment that referenced this pull request Mar 4, 2024
## [0.0.20](v0.0.19...v0.0.20) (2024-03-04)

### Chores

* **deps:** bump wntrblm/nox from 2023.04.22 to 2024.03.02 ([#57](#57)) ([d177375](d177375)), closes [wntrblm/nox#762](wntrblm/nox#762) [wntrblm/nox#787](wntrblm/nox#787) [wntrblm/nox#730](wntrblm/nox#730) [wntrblm/nox#780](wntrblm/nox#780) [wntrblm/nox#770](wntrblm/nox#770) [wntrblm/nox#707](wntrblm/nox#707) [wntrblm/nox#687](wntrblm/nox#687) [wntrblm/nox#756](wntrblm/nox#756) [wntrblm/nox#652](wntrblm/nox#652) [wntrblm/nox#712](wntrblm/nox#712) [wntrblm/nox#781](wntrblm/nox#781) [wntrblm/nox#786](wntrblm/nox#786) [wntrblm/nox#684](wntrblm/nox#684) [wntrblm/nox#723](wntrblm/nox#723) [wntrblm/nox#725](wntrblm/nox#725) [wntrblm/nox#714](wntrblm/nox#714) [wntrblm/nox#715](wntrblm/nox#715) [wntrblm/nox#696](wntrblm/nox#696) [wntrblm/nox#774](wntrblm/nox#774) [wntrblm/nox#782](wntrblm/nox#782) [wntrblm/nox#722](wntrblm/nox#722) [wntrblm/nox#724](wntrblm/nox#724) [wntrblm/nox#721](wntrblm/nox#721) [wntrblm/nox#744](wntrblm/nox#744) [wntrblm/nox#738](wntrblm/nox#738) [wntrblm/nox#762](wntrblm/nox#762) [wntrblm/nox#787](wntrblm/nox#787) [wntrblm/nox#730](wntrblm/nox#730) [wntrblm/nox#780](wntrblm/nox#780) [wntrblm/nox#770](wntrblm/nox#770) [wntrblm/nox#707](wntrblm/nox#707) [wntrblm/nox#687](wntrblm/nox#687) [wntrblm/nox#756](wntrblm/nox#756) [wntrblm/nox#652](wntrblm/nox#652) [wntrblm/nox#712](wntrblm/nox#712) [wntrblm/nox#781](wntrblm/nox#781) [wntrblm/nox#786](wntrblm/nox#786) [wntrblm/nox#684](wntrblm/nox#684) [wntrblm/nox#723](wntrblm/nox#723) [wntrblm/nox#725](wntrblm/nox#725) [wntrblm/nox#714](wntrblm/nox#714) [wntrblm/nox#715](wntrblm/nox#715) [wntrblm/nox#696](wntrblm/nox#696) [wntrblm/nox#774](wntrblm/nox#774) [wntrblm/nox#782](wntrblm/nox#782) [wntrblm/nox#722](wntrblm/nox#722) [wntrblm/nox#724](wntrblm/nox#724) [wntrblm/nox#721](wntrblm/nox#721) [wntrblm/nox#744](wntrblm/nox#744) [#789](https://github.com/msclock/sphinx-deployment/issues/789) [#787](https://github.com/msclock/sphinx-deployment/issues/787) [#786](https://github.com/msclock/sphinx-deployment/issues/786) [#781](https://github.com/msclock/sphinx-deployment/issues/781) [#784](https://github.com/msclock/sphinx-deployment/issues/784) [#780](https://github.com/msclock/sphinx-deployment/issues/780) [#730](https://github.com/msclock/sphinx-deployment/issues/730) [#782](https://github.com/msclock/sphinx-deployment/issues/782) [#783](https://github.com/msclock/sphinx-deployment/issues/783) [#762](https://github.com/msclock/sphinx-deployment/issues/762)

### CI

* set proper permission for preview job ([#56](#56)) ([d65e8a1](d65e8a1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

'virtualenv.version' has no attribute 'version' in test_virtualenv.py
4 participants