Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GitHub Actions uses example runnable #662

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Make GitHub Actions uses example runnable #662

merged 1 commit into from
Oct 20, 2022

Conversation

paw-lu
Copy link
Contributor

@paw-lu paw-lu commented Oct 20, 2022

Currently example for GitHub actions will not run, and needs a version tag. Defaulted to using @latest.

(At least partially) closes #643

Thanks for all the work here. Really enjoy using nox.

DiddiLeija
DiddiLeija approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me!

@FollowTheProcess FollowTheProcess merged commit 6cd59b7 into wntrblm:main Oct 20, 2022
@FollowTheProcess
Copy link
Collaborator

Thanks @paw-lu 🎉

@henryiii
Copy link
Collaborator

Where is "latest" defined? I don't see a latest tag or branch. @main would point at main, or you can set a tag like @2022.8.7, but I don't see a latest. Also, never write @latest without the tick-marks around it, you tagged someone named "latest". :)

@henryiii
Copy link
Collaborator

henryiii commented Oct 20, 2022 •
edited
Loading

There seems to be an action https://github.com/marketplace/actions/latest-tag, but we aren't using it here.

@FollowTheProcess
Copy link
Collaborator

Ahh good spot, I saw @latest and assumed it would work based on other actions but they aren't composite ones are they!

@FollowTheProcess
Copy link
Collaborator

#664 is a quick fix 🙂

@DiddiLeija DiddiLeija mentioned this pull request Oct 20, 2022
Merged
@wpk-nist-gov wpk-nist-gov mentioned this pull request Dec 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiddiLeija DiddiLeija DiddiLeija approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The new GitHub action does not work?
4 participants
@paw-lu @FollowTheProcess @henryiii @DiddiLeija