Add some missing generic type arguments #595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds generic type arguments to type hints in
sessions.py
, I did not have time to go through the whole codebase unfortunately.The benefit of adding type arguments is that type checkers like Pyright will complain if you access a variable that has a potentially unknown type, for example I ran into this:
If you want to avoid errors like these in the future, I'd highly recommend adding pyright to CI and using --verifytypes.