Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Enable color output from Nox, pytest, and pre-commit #542

Merged
merged 2 commits into from
Dec 27, 2021
Merged

ci: Enable color output from Nox, pytest, and pre-commit #542

merged 2 commits into from
Dec 27, 2021

Conversation

cjolowicz
Copy link
Collaborator

@cjolowicz cjolowicz commented Dec 27, 2021 •
edited
Loading

This enables color output on GitHub Actions for Nox itself, as well as pytest and pre-commit, using workflow-wide environment variables. Nox and pytest support FORCE_COLOR, while pre-commit supports PRE_COMMIT_COLOR.

@cjolowicz
Copy link
Collaborator Author

There are test failures because FORCE_COLOR conflicts with tests for --nocolor.

(On the bright side, the test failures are now beautiful to look at. 😆 )

@cjolowicz cjolowicz added the ci Issues relating to nox's CI pipeline label Dec 27, 2021
@FollowTheProcess
Copy link
Collaborator

Pretty! I like it

@FollowTheProcess FollowTheProcess merged commit fcaafa1 into main Dec 27, 2021
@FollowTheProcess FollowTheProcess deleted the gha-color branch December 27, 2021 17:24
@FollowTheProcess
Copy link
Collaborator

Thanks @cjolowicz 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FollowTheProcess FollowTheProcess FollowTheProcess approved these changes

Assignees
No one assigned
Labels
ci Issues relating to nox's CI pipeline
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjolowicz @FollowTheProcess