Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate use of session.install() without a virtual env #537

Merged

Conversation

Tolker-KU
Copy link
Contributor

Close #503.

I've scanned the docs and cannot see anything that should be changed based on this change. Please correct me if I'm wrong.

Also feel free to chime in on the wording of the warning message.

nox/sessions.py Outdated Show resolved Hide resolved
@cjolowicz
Copy link
Collaborator

cjolowicz commented Dec 27, 2021

I've scanned the docs and cannot see anything that should be changed based on this change. Please correct me if I'm wrong.

I also did not find anything. Should we add a note to config.rst explaining this, though?

It can go into the section introducing venv_backend="none", and can be worded similar to the deprecation warning. Can happen here or in a follow-up PR.

@Tolker-KU Tolker-KU force-pushed the feature/deprecate_install_in_passthrough_env branch 3 times, most recently from 2e2d40b to 5a7209e Compare December 27, 2021 12:41
@Tolker-KU Tolker-KU force-pushed the feature/deprecate_install_in_passthrough_env branch from 5a7209e to 3eac704 Compare December 27, 2021 12:44
docs/config.rst Outdated Show resolved Hide resolved
@FollowTheProcess
Copy link
Collaborator

FollowTheProcess commented Dec 27, 2021

Is the intention here to keep this warning for 1 release (presumably the next one?) and then in the following release make it so that doing this will become an actual error? I don't use calver so I don't know if there are any specific rules regarding this.

If so we should probably have a separate issue to track this as I know at least my memory isn't that good!

@cjolowicz
Copy link
Collaborator

cjolowicz commented Dec 27, 2021

Is the intention here to keep this warning for 1 release (presumably the next one?) and then in the following release make it so that doing this will become an actual error?

Yes.

I don't use calver so I don't know if there are any specific rules regarding this.

We don't have any specific rules that I know of, but waiting one release should be enough IMO.

If so we should probably have a separate issue to track this as I know at least my memory isn't that good!

Opened #541 for this.

@cjolowicz cjolowicz merged commit c94b62e into wntrblm:main Dec 27, 2021
@cjolowicz
Copy link
Collaborator

Thanks @Tolker-KU

@Tolker-KU Tolker-KU deleted the feature/deprecate_install_in_passthrough_env branch December 27, 2021 16:57
DiddiLeija referenced this pull request in DiddiLeija/nox Jan 23, 2022
We already gave a "deprecation phase" for this in theacodes#537, and now it's time to disable this.

This commit will break tests, though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Running with --no-venv causes session.install to use unexpected interpreter
3 participants