Correct bin paths in CondaEnv for Windows #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tolker-KU
force-pushed
the
feature/windows_conda_bin_paths
branch
from
df223ab
to
a364bdf
Compare
cjolowicz
approved these changes
Dec 25, 2021
There was a problem hiding this comment.
LGTM
Disclaimer: I have no knowledge of conda internals. Took a look at the conda.activators module. Shell activators inherit from a common base class _Activator. Invoking its activate method ends up constructing this list of PATH entries for Windows, via the following call chain:
activate
build_activate
_build_activate_stack
_add_prefix_to_path
_get_starting_path_list
_get_path_dirs
See https://github.com/conda/conda/blob/f60f0f1643af04ed9a51da3dd4fa242de81e32f4/conda/activate.py#L563-L572 as quoted in the code comment.
|
@thatcr does this fix your issue? |
I've run the example noxfile stated in the issue on Windows using the patched version of Nox and it works as accepted. (Also verified that it is failing on HEAD). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #514.