Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix missing 3.8 -> 3.9 for CI #529

Merged
merged 1 commit into from
Dec 24, 2021

Conversation

henryiii
Copy link
Collaborator

Followup to #528

@Tolker-KU
Copy link
Contributor

Tolker-KU commented Dec 23, 2021

Maybe not in scope here, but I wonder if we should give the lint and docs steps the '--error-on-missing-interpreters' flag in CI to avoid this flying under the radar again?

@henryiii
Copy link
Collaborator Author

Do they need to be pinned to a specific Python, or could they just use the default?

@FollowTheProcess
Copy link
Collaborator

Do they need to be pinned to a specific Python, or could they just use the default?

I've often thought this when running them locally and always having to use --force-python to run them. I always assumed there was a valid reason behind pinning these sessions?

If this is not the case, I think just using the default is the way to go 👍🏻

@FollowTheProcess
Copy link
Collaborator

Maybe not in scope here, but I wonder if we should give the lint and docs steps the '--error-on-missing-interpreters' flag in CI to avoid this flying under the radar again?

This is a good idea if we cannot drop the pin for some compatibility reaason.

I've raised an issue #531 to track this, thanks for bringing it up (and quickly fixing it @henryiii !)

@henryiii henryiii deleted the henryiii/ci/fix38 branch December 28, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants