-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mamba environment #448
Conversation
Does this look like a good direction? Happy to polish it off if so. Also, shouldn't mamba fall back to conda if mamba is not available? I rather think so? |
@theacodes any direction here on the way you'd like it to go? |
Ah, I'm sorry this kept flying under my radar. This approach is great. |
847acb5
to
8c9e374
Compare
This implementation is just a simple "mamba" can be chosen implementation - it does not auto-switch to conda if mamba is not available, or install mamba for you. A user could detect this when setting the backend in their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @henryiii
Minor nit for the docs, otherwise this looks good to me! Good call about PassthroughEnv
also needing conda_cmd
.
Co-authored-by: Claudio Jolowicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🚀
Closes #444.
Initial prototype, no docs or tests yet. Does this look like a good way to do it?