Add default SMTP authentication type to NewClient #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a regression introduced in v0.5.0. We now set the default SMTPAuthType to NOAUTH in NewClient. Enhanced documentation and added test cases for different SMTP authentication scenarios.
Renamed environment variables from TEST_USER and TEST_PASS to TEST_SMTPAUTH_USER and TEST_SMTPAUTH_PASS for clarity and consistency in setting SMTP authentication credentials. This change ensures that the correct credentials are applied during tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
==========================================
- Coverage 86.85% 86.55% -0.30%
==========================================
Files 26 26
Lines 2350 2351 +1
==========================================
- Hits 2041 2035 -6
- Misses 179 181 +2
- Partials 130 135 +5 ☔ View full report in Codecov by Sentry. |
wneessen
deleted the
bug/332_server-does-not-support-smtp-auth-error-when-using-localhost-in-v050
branch
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in v0.5.0.
SMTPAuthNoAuthis now changed from an empty string to "NOAUTH". This value is set as default for the Client inNewClient. This way we always have a fixed assignment and an empty string would not skip authentication. Theauth()method has been updated to either assign thesmtp.Authfunction ifSMTPAuthTypeis not set to "NOAUTH" or skip the part there is already an auth function set (this would only happen whenSetSMTPAuthCustomor"WithSMTPAuthCustomwere used.If
SMTPAuthTypeis set to an empty string, the authentication assignment would fail as it is a not supported mechanism, therefore making sure that the client wouldn't accidentaly skip the authentication at all.A test has been added to test different auth switching scenarios (using supported, unsupported and custom auth functions). The documentation for
auth()has been updated accordingly to make it more clear, what's happening.This should fix the regression described in #332 and #328 but should also address the "empty string" issue, we had before.