Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo / inconsistency in Msg method #278

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

alfa-alex
Copy link
Contributor

The method SetAttachements is probably a typo: In all other methods it's correctly written "Attachments", so this method should be aligned.

@wneessen
Copy link
Owner

Appreciate the PR @alfa-alex!

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.88%. Comparing base (3e4d8e3) to head (7caf0b8).

Files Patch % Lines
msg.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   85.35%   79.88%   -5.48%     
==========================================
  Files          25       25              
  Lines        2076     2078       +2     
==========================================
- Hits         1772     1660     -112     
- Misses        179      298     +119     
+ Partials      125      120       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wneessen
Copy link
Owner

It'll fix the linter errors in a dedicated PR. No need to do anything here

@wneessen wneessen merged commit 3311e4d into wneessen:main Aug 14, 2024
22 of 27 checks passed
@wneessen wneessen mentioned this pull request Aug 14, 2024
@alfa-alex
Copy link
Contributor Author

Appreciate the PR @alfa-alex!

You're welcome. And thank you for the fast merge of this MR. And, even more, for your great work on this library! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants