Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Handle missing Content-Type as plain text #272

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

wneessen
Copy link
Owner

@wneessen wneessen commented Aug 2, 2024

Added a new example email and modified tests to include an RFC 5322 format. Refactored the code to handle cases where the Content-Type header is missing by defaulting to plain text (7bit, US-ASCII). Deleted redundant test cases that no longer apply.

This PR closes #271

Added a new example email and modified tests to include an RFC 5322 format. Refactored the code to handle cases where the Content-Type header is missing by defaulting to plain text (7bit, US-ASCII). Deleted redundant test cases that no longer apply.
@wneessen wneessen linked an issue Aug 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (3ca2968) to head (69b1dc2).

Files Patch % Lines
eml.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   85.31%   85.26%   -0.06%     
==========================================
  Files          25       25              
  Lines        2070     2076       +6     
==========================================
+ Hits         1766     1770       +4     
- Misses        178      180       +2     
  Partials      126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wneessen wneessen merged commit f701b23 into main Aug 2, 2024
27 of 29 checks passed
@wneessen wneessen deleted the bug/271_parsing-rfc5322-example-a11-fails branch August 2, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing rfc5322 example A11 fails
1 participant