This repository has been archived by the owner on Jan 26, 2019. It is now read-only.
Merge react scripts 1.1.1 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* extra watch options regex to react-dev-utils * fix regex * add test * fix eslint error * include react-dev-utils test in CI script * attempt to fix import error * attempt to fix error on CI * Update .eslintrc
* one-line waiting for app start * remove fixed todo
* improve eject message * cross os implementation
* add —use-npm flag to bypass yarn * add e2e test for —use-npm flag
* docs: adding section about debugging tests * docs: removing node-inspector references * docs: replacing terminal command with npm script * Update README.md
Fix another dead link
This fixes the broken link to removed `href-no-hash.md` file, that is no longer available in the [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) plugin (since [6.0.0](https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/a14617528cda23c6c88902ace1d083e4e13ac271/CHANGELOG.md))
the code got updated from `detect()` to `choosePort` while the comment did not.
Replaced `it's` with `its`
The launch configuration code provided is not compatible with VSCode since version 1.19. The proposed documentation change is based on the response by a VSCode team member. References: facebook/create-react-app#3602 (comment) microsoft/vscode#40293 (comment)
* use safer/more aesthetic syntax * fix typo
Replace `provide a lot value` with `provide a lot of value`.
* Fix path regex match bug * Use the escape-string-regexp package to escape regex characters * Remove redundant character escape from path * Add removed escape of backslashes
* Add warning when HOST environment variable is set (#3719) * Improve HOST environment variable warning message * Adjust text and message Closes #3719
* Test Node 9 on CI * Oops
See #3837
Update User Guide's README.md to include `json` and `css` files in the command to format the entire project for the first time with prettier, that it's consistent with the `lint-staged` command.
This reverts commit bab2c29. I meant to apply it to `next` instead.
|
I'll have a look at this tomorrow, too busy today. |
|
👍
…On 15 Mar 2018, 12:08 +0000, Christian Linne ***@***.***>, wrote:
I'll have a look at this tomorrow, too busy today.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
DorianGrey
reviewed
Mar 16, 2018
There was a problem hiding this comment.
Looks good, except the failing travis build.
The simple test fails due to missing yarn installation. install does not fail, but does not even run due to the missing yarn installation.
I've seen that you did not merge the .travis.yml from the CRA repo (this version). Was this intended? It might be the cause of the problem.
|
Updating |
|
@DorianGrey i'm having trouble working out how to fix the build scripts from cra. They're now doing a bunch of stuff that we don't want to (like publishing a prerelease). I am going to test this manually and merge without CI going green. Then when I break the fork link I will work on a new testing method. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.