Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Button as Link #533

Closed
catiarodriguescosta opened this issue Dec 15, 2020 · 8 comments
Closed

Documentation for Button as Link #533

catiarodriguescosta opened this issue Dec 15, 2020 · 8 comments
Assignees
Labels
Awaiting go live ✅ This issue has been completed and is awaiting go live from the release branch feature_request released

Comments

@catiarodriguescosta
Copy link
Contributor

catiarodriguescosta commented Dec 15, 2020

Could you create a text for Button as Link? It is a button with Link appearance to be integrated in the button page component for the design system. :)

Button as Link

What does it do?

When to use it?

When not to use it?

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.53. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@somtmee
Copy link

somtmee commented Dec 15, 2020

@catiarodriguescosta sure thing. @mrmjprice - can you share some information on what it does, when to use it and when not to use it? I've checked NHS and GOV service manuals but can't find a similar component

@mrmjprice
Copy link
Contributor

Am going to defer the documentation to @KaterinaKir and @jkmnch

I would just mention a recent GOV.UK change where they changed the footer feedback loop text links to buttons. This was to meet accessibility regs as they decided the link didn't behave like a link, more like an interface button.

The discussion was in x-gov Slack, so it might be worth asking for any research in the design system channel

@somtmee
Copy link

somtmee commented Dec 16, 2020 via email

@jkmnch jkmnch self-assigned this Dec 16, 2020
@mrmjprice mrmjprice removed their assignment Dec 16, 2020
@jkmnch
Copy link
Contributor

jkmnch commented Jan 14, 2021

What does it do?

  • Behaves the same as a button, but uses the Link styling
  • Performs an action on the page instead of directing the user to an internal or external page
  • Uses the tag for accessibility

When to use it?

  • When a user needs to perform an action on a page
  • When there is limited space for a button

When not to use it?

  • The start of a process
  • When you want to direct the user to an internal or external page

@catiarodriguescosta
Copy link
Contributor Author

Thank you Jake @jkmnch!

@catiarodriguescosta catiarodriguescosta added the Awaiting go live ✅ This issue has been completed and is awaiting go live from the release branch label Jan 14, 2021
@wmcadigital-admin
Copy link

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@houbly
Copy link
Contributor

houbly commented Jan 21, 2021

This update is now live

@houbly houbly closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting go live ✅ This issue has been completed and is awaiting go live from the release branch feature_request released
Projects
None yet
Development

No branches or pull requests

7 participants