Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shadow_node #66

Merged
merged 22 commits into from
Oct 25, 2024
Merged

feat: add shadow_node #66

merged 22 commits into from
Oct 25, 2024

Conversation

WillPower3309
Copy link
Member

No description provided.

@WillPower3309 WillPower3309 marked this pull request as draft October 18, 2024 06:26
render/fx_renderer/fx_pass.c Outdated Show resolved Hide resolved
render/fx_renderer/fx_pass.c Show resolved Hide resolved
types/scene/wlr_scene.c Outdated Show resolved Hide resolved
types/scene/wlr_scene.c Show resolved Hide resolved
types/scene/wlr_scene.c Show resolved Hide resolved
@WillPower3309
Copy link
Member Author

WillPower3309 commented Oct 19, 2024

remaining work:

  • render around a defined wlr_box to support offset (or maybe we just add the offset back - that may be better actually)
  • properly size and position the border node -> we shouldn't need the comp to take blur_sigma into account when defining the shadow width and height. See the scene-graph example for size / position of the shadow node to see what I mean
  • update tinywl: draw shadow behind surface
  • support transforms
  • use node xdg geometry
  • Clean up the window box detection logic

@ErikReider ErikReider mentioned this pull request Oct 19, 2024
3 tasks
@WillPower3309
Copy link
Member Author

My tinywl work is barely functional, will need more work

tinywl/tinywl.c Outdated Show resolved Hide resolved
tinywl/tinywl.c Outdated Show resolved Hide resolved
tinywl/tinywl.c Outdated Show resolved Hide resolved
types/scene/wlr_scene.c Outdated Show resolved Hide resolved
types/scene/wlr_scene.c Outdated Show resolved Hide resolved
include/scenefx/types/wlr_scene.h Show resolved Hide resolved
@WillPower3309
Copy link
Member Author

Updated remaining work comment

@WillPower3309
Copy link
Member Author

We can support multiple "window boxes" as follow-up work. We can use https://www.lighthouse3d.com/tutorials/glsl-tutorial/uniform-variables/ as a handy reference here

@WillPower3309 WillPower3309 marked this pull request as ready for review October 25, 2024 06:04
Copy link
Member

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work as expected, LGTM! :)

@WillPower3309 WillPower3309 merged commit d998099 into main Oct 25, 2024
@ErikReider ErikReider deleted the shadow_node branch October 25, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants