-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX Renderer] Add blur #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, can you explain at a high level how we handle blur ignore transparent in scene? Reviewing from my phone and that bit of logic is the only one I'm having a nuisance tracking
Thanks for your patience in waiting for a review! |
It's actually pretty simple, the comp needs to call the The actual wlr_scene part of it is the same as we do in SwayFX where we pass a bool to the blur function indicating whether we want to ignore the transparent regions or not. (Render the surface texture and stencil it, etc…) |
What we can do is to separate the renderer impl and the scene impl into separate PRs to make it easier for you to review. What do you think of that idea @WillPower3309 ? |
If you don't mind that would be great! |
0651668
to
9cecd94
Compare
Done :) |
9cecd94
to
541f4b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor comments, otherwise LGTM
Done! :) |
Fixes: #14
Supersedes: #22
TODO: