[WIP] added missing 'partition' argument to slurm launcher #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkmann
changed the title
|
Creation of the extended class work fine, but the map() function complains about non-matching character lengths on an attribute check. Did not get to the bottom of it. |
wlandau
reviewed
Oct 11, 2023
| @@ -49,6 +49,8 @@ | |||
| #' SLURM cluster. `slurm_time_minutes = 60` translates to a line of | |||
| #' `#SBATCH --time=60` in the SLURM job script. `slurm_time_minutes = NULL` | |||
| #' omits this line. | |||
| #' @param slurm_partition Character of length 1, name of the slurm partition to | |||
| #' create workers on. | |||
There was a problem hiding this comment.
Would be great to have a mention of how this translates into the --partition flag, as in the above @param descriptions. Also how a NULL value omits the flag.
You might need development |
|
I am actually gearing up for a set of releases, so I will merge this now. Thanks! |
4 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prework
Related GitHub issues and pull requests
Summary
Make the slurm partition configurable for
crew_controller_slurm()