change default seconds_idle to 300

wlandau · Nov 14, 2024 · 1919a64 · 1919a64
1 parent b8d4c37
commit 1919a64
Show file tree

Hide file tree

Showing 20 changed files with 19 additions and 20 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -6,6 +6,7 @@
 * Organize arguments into options lists.
 * Use `crashes_error` from `crew`.
 * Implement retryable options for memory, cores, GPUs, wall time, and SLURM partition (#48, @stemangiola).
+* Set default `seconds_idle` to 300.
 
 # crew.cluster 0.3.2
 

diff --git a/R/crew_controller_lsf.R b/R/crew_controller_lsf.R
@@ -34,7 +34,7 @@ crew_controller_lsf <- function(
   seconds_interval = 0.25,
   seconds_timeout = 60,
   seconds_launch = 86400,
-  seconds_idle = Inf,
+  seconds_idle = 300,
   seconds_wall = Inf,
   seconds_exit = NULL,
   retry_tasks = TRUE,

diff --git a/R/crew_controller_pbs.R b/R/crew_controller_pbs.R
@@ -30,7 +30,7 @@ crew_controller_pbs <- function(
   seconds_interval = 0.25,
   seconds_timeout = 60,
   seconds_launch = 86400,
-  seconds_idle = Inf,
+  seconds_idle = 300,
   seconds_wall = Inf,
   seconds_exit = NULL,
   retry_tasks = TRUE,

diff --git a/R/crew_controller_sge.R b/R/crew_controller_sge.R
@@ -30,7 +30,7 @@ crew_controller_sge <- function(
   seconds_interval = 0.25,
   seconds_timeout = 60,
   seconds_launch = 86400,
-  seconds_idle = Inf,
+  seconds_idle = 300,
   seconds_wall = Inf,
   seconds_exit = NULL,
   retry_tasks = TRUE,

diff --git a/R/crew_controller_slurm.R b/R/crew_controller_slurm.R
@@ -34,7 +34,7 @@ crew_controller_slurm <- function(
   seconds_interval = 0.25,
   seconds_timeout = 60,
   seconds_launch = 86400,
-  seconds_idle = Inf,
+  seconds_idle = 300,
   seconds_wall = Inf,
   seconds_exit = NULL,
   retry_tasks = TRUE,

diff --git a/R/crew_launcher_cluster.R b/R/crew_launcher_cluster.R
@@ -23,7 +23,7 @@ crew_launcher_cluster <- function(
   seconds_interval = 0.5,
   seconds_timeout = 60,
   seconds_launch = 86400,
-  seconds_idle = Inf,
+  seconds_idle = 300,
   seconds_wall = Inf,
   tasks_max = Inf,
   tasks_timers = 0L,

diff --git a/R/crew_launcher_lsf.R b/R/crew_launcher_lsf.R
@@ -33,7 +33,7 @@ crew_launcher_lsf <- function(
   seconds_interval = 0.5,
   seconds_timeout = 60,
   seconds_launch = 86400,
-  seconds_idle = Inf,
+  seconds_idle = 300,
   seconds_wall = Inf,
   tasks_max = Inf,
   tasks_timers = 0L,

diff --git a/R/crew_launcher_pbs.R b/R/crew_launcher_pbs.R
@@ -34,7 +34,7 @@ crew_launcher_pbs <- function(
   seconds_interval = 0.5,
   seconds_timeout = 60,
   seconds_launch = 86400,
-  seconds_idle = Inf,
+  seconds_idle = 300,
   seconds_wall = Inf,
   tasks_max = Inf,
   tasks_timers = 0L,

diff --git a/R/crew_launcher_sge.R b/R/crew_launcher_sge.R
@@ -32,7 +32,7 @@ crew_launcher_sge <- function(
   seconds_interval = 0.5,
   seconds_timeout = 60,
   seconds_launch = 86400,
-  seconds_idle = Inf,
+  seconds_idle = 300,
   seconds_wall = Inf,
   tasks_max = Inf,
   tasks_timers = 0L,

diff --git a/R/crew_launcher_slurm.R b/R/crew_launcher_slurm.R
@@ -35,7 +35,7 @@ crew_launcher_slurm <- function(
   seconds_interval = 0.5,
   seconds_timeout = 60,
   seconds_launch = 86400,
-  seconds_idle = Inf,
+  seconds_idle = 300,
   seconds_wall = Inf,
   tasks_max = Inf,
   tasks_timers = 0L,

diff --git a/man/crew_controller_lsf.Rd b/man/crew_controller_lsf.Rd
diff --git a/man/crew_controller_pbs.Rd b/man/crew_controller_pbs.Rd
diff --git a/man/crew_controller_sge.Rd b/man/crew_controller_sge.Rd
diff --git a/man/crew_controller_slurm.Rd b/man/crew_controller_slurm.Rd
diff --git a/man/crew_launcher_cluster.Rd b/man/crew_launcher_cluster.Rd
diff --git a/man/crew_launcher_lsf.Rd b/man/crew_launcher_lsf.Rd
diff --git a/man/crew_launcher_pbs.Rd b/man/crew_launcher_pbs.Rd
diff --git a/man/crew_launcher_sge.Rd b/man/crew_launcher_sge.Rd
diff --git a/man/crew_launcher_slurm.Rd b/man/crew_launcher_slurm.Rd
diff --git a/tests/sge/retries.R b/tests/sge/retries.R
@@ -1,6 +1,4 @@
 # Watch the number of cores allocated to each worker instance
-
-
 library(crew.cluster)
 library(testthat)