Skip to content

Commit

Permalink
Bug 1725524: types/aws/default: move ap-northeast-2 to m5 instance class
Browse files Browse the repository at this point in the history
AWS allows m4 class for reserved instances in all AZs for ap-northeast-2

```console
aws --region ap-northeast-2 ec2 describe-reserved-instances-offerings --instance-tenancy default --instance-type m4.large --product-description 'Linux/UNIX' --filters Name=scope,Values='Availability Zone' | jq -r '[.ReservedInstancesOfferings[].AvailabilityZone] | sort | unique[]'
ap-northeast-2a
ap-northeast-2b
ap-northeast-2c
```

But the on-demand instances in ap-norteast-2b was failing with error
```
Unsupported: Your requested instance type (m4.xlarge) is not supported in your requested Availability Zone (ap-northeast-2b). Please retry your request by not specifying an Availability Zone or choosing ap-northeast-2a, ap-northeast-2c.
```

So moving to m5 class for ap-northeast-2 should allow creating control plane instances in all Zones. (the default configuration)
  • Loading branch information
abhinavdahiya committed Jul 2, 2019
1 parent 056c276 commit 3085753
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions pkg/types/aws/defaults/platform.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@ import (

var (
defaultMachineClass = map[string]string{
"ap-east-1": "m5",
"eu-north-1": "m5",
"eu-west-3": "m5",
"us-gov-east-1": "m5",
"us-west-2": "m5",
"ap-east-1": "m5",
"ap-northeast-2": "m5",
"eu-north-1": "m5",
"eu-west-3": "m5",
"us-gov-east-1": "m5",
"us-west-2": "m5",
}
)

Expand Down

0 comments on commit 3085753

Please sign in to comment.