Skip to content

Commit

Permalink
config: Explicitly put hooks in the runtime namespace
Browse files Browse the repository at this point in the history
The language from 15dee2e (runtime: Add prestart/poststop hooks,
2015-08-03, opencontainers#34) landed well before we had glossary entries for the
runtime and container namespaces (from 5dad125, config-linux: Specify
host mount namespace for namespace paths, 2015-12-18, opencontainers#275).  Now that
we do have language to cover that concept, it's better to explicitly
say that hooks run in the runtime namespace instead of leaving it to
the reader to extrapolate from the filesystem requirement.

With the new namespace wording, the "host's filesystem" wording is
somewhat redundant.  I've left it in though, because I think it helps
to have a more gradual transition from hook paths to namespaces.

Signed-off-by: W. Trevor King <[email protected]>
  • Loading branch information
wking committed Apr 30, 2016
1 parent e5e603f commit a5af569
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions config.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ Hooks allow one to run code before/after various lifecycle events of the contain
Hooks MUST be called in the listed order.
The state of the container is passed to the hooks over stdin, so the hooks could get the information they need to do their work.

Hook paths are absolute and are executed from the host's filesystem.
Hook paths are absolute and are executed from the host's filesystem in the [runtime namespace][runtime-namespace].

### Prestart

Expand Down Expand Up @@ -615,5 +615,5 @@ Here is a full example `config.json` for reference.
}
```


[runtime-namespace]: glossary.md#runtime-namespace
[uts-namespace]: http://man7.org/linux/man-pages/man7/namespaces.7.html

0 comments on commit a5af569

Please sign in to comment.