Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search also for newer versions (>= 2.0.x) of GDAL dll on Windows #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

joa-quim
Copy link

Add names of the GDAL DLL as currently in http://www.gisinternals.com and the GMT installer

Add names of the GDAL DLL as currently in http://www.gisinternals.com and the GMT installer
@yeesian
Copy link
Collaborator

yeesian commented Nov 23, 2015

what happens if you do aliases=["gdal","gdal111","gdal201","gdal_w32","gdal_w64"] instead?

@yeesian
Copy link
Collaborator

yeesian commented Nov 23, 2015

Also, why is this a different PR from #20?

@joa-quim
Copy link
Author

what happens if you do aliases=["gdal","gdal111","gdal201","gdal_w32","gdal_w64"] instead?

Not sure. It may work as well, "gdal_w32" is the 32 bits version of the same dll

@joa-quim
Copy link
Author

Also, why is this a different PR from #20?

Well, it was you who asked me to change build.jl instead. This is intended to replace #20

@yeesian
Copy link
Collaborator

yeesian commented Nov 23, 2015

Oh, you could have made the changes to #20 directly, since it's under the same umbrella issue of updating the build script. I don't mean to patronize; just trying to understand the intent of this PR.

Not sure. It may work as well, "gdal_w32" is the 32 bits version of the same dll

If it works, I think it'll be preferable to stick to just expanding the list of aliases.

@joa-quim
Copy link
Author

Ok, I thought that since this change a different file I should do another PR.
And regarding the aliases, what I can say is that for me it works as well to have only
libgdal = library_dependency("libgdal",aliases=["gdal","gdal111","gdal201","gdal_w64","gdal_w32"])
ah, and btw, I don't know how to change an existing PR, only to make anew one.

@meggart
Copy link
Collaborator

meggart commented Nov 24, 2015

LGTM

@yeesian
Copy link
Collaborator

yeesian commented Nov 24, 2015

ah, and btw, I don't know how to change an existing PR, only to make anew one.

I've found the tutorials by atlassian pretty helpful when starting out:

Given that we're pretty strapped to github (+travis+appveyor) in our infrastructural support, it'll be good to spend some time to learn them well for future PRs. Let us know if we can help walk you through any of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants