Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: numeric accuracy for f16 #1

Closed
wants to merge 20 commits into from
Closed

fix: numeric accuracy for f16 #1

wants to merge 20 commits into from

Conversation

wjones127
Copy link
Owner

@wjones127 wjones127 commented Feb 28, 2024 •
edited
Loading

Changes:

  • Adds property-based tests that assert that f16 kernels match the f32 kernel results across the whole space of f16 vectors.
  • Merged Normalize trait into the L2 trait
  • Simplified Cosine trait
  • Make sure norm_l2 function actually dispatches to SIMD implementations.

@wjones127 wjones127 closed this Mar 11, 2024
wjones127 pushed a commit that referenced this pull request Jul 25, 2024
@broccoliSpicy
perf: speed up fsst decompression (lancedb#2626)
fbf7a4a 
before:
<img width="710" alt="Screenshot 2024-07-21 at 4 24 44 PM"
src="https://github.com/user-attachments/assets/65a953ac-bbbf-4244-b3fa-d5b7c368806e">

after:
<img width="589" alt="Screenshot 2024-07-21 at 4 28 49 PM"
src="https://github.com/user-attachments/assets/16a20200-d8f2-4e5a-8e59-2be42281222e">


to reproduce:
`cargo run --release --example benchmark `
in `rust/lance-encoding/compression-algo/fsst`

machine info:
`11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz`
`Linux 192 5.10.0-28-amd64 #1 SMP Debian 5.10.209-2 (2024-01-31) x86_64
GNU/Linux`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wjones127