Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML parsing of rotations #30

Closed
DrLSimon opened this issue Nov 15, 2023 · 1 comment
Closed

XML parsing of rotations #30

DrLSimon opened this issue Nov 15, 2023 · 1 comment

Comments

@DrLSimon
Copy link

Hi,
This is just a minor comment w.r.t the parser of Transform, for rotation, when the axis provided in the XML is not normalized, the produced transformation is actually not a rotation.
Is this the intended behaviour. If not I would suggest normalizing the axis in the parser, here :
parser.cpp#L270C1-L271C1

Best regards, Loic Simon

wjakob added a commit that referenced this issue Nov 15, 2023
@wjakob
Copy link
Owner

wjakob commented Nov 15, 2023

Thanks for the report Loic, this is fixed now.

@wjakob wjakob closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants