[th/validate-args] testConfig: improve validation of {ConfServer,ConfClient}.args #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thom311
force-pushed
the
th/validate-args
branch
2 times, most recently
from
c45422d to
55fa7a2
Compare
thom311
force-pushed
the
th/validate-args
branch
from
55fa7a2 to
b371804
Compare
| @@ -145,6 +151,14 @@ def _construct_args(pctx2: StructParseParseContext) -> tuple[str, ...]: | |||
|
|
|||
| return typing.cast("T2", result) | |||
|
|
|||
| def _validate(self, test_type: TestType) -> None: | |||
| if self.args is not None: | |||
| if test_type not in (TestType.SIMPLE,): | |||
There was a problem hiding this comment.
we only support SIMPLE test type?
There was a problem hiding this comment.
this parameter was added especially for "simple", to tweak what the script does. The script is mainly intended for manually hacking it for some ad-hoc testing, so passing additional parameters to it may make sense.
passing args to iperf or netperf tools probably would make sense. But it's not implemented yet, hence it's currently rejected.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.