Add slug to product-search results #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorj
commented
May 29, 2017
| // @TODO: more assertions | ||
| } finally { | ||
| VCR::turnOff(); | ||
| static::$historyContainer = []; // @FIXME: small hack due to fr3d/swagger-assertions not properly checking URL query non-string types. |
There was a problem hiding this comment.
J'ai galéré pas mal de temps là dessus, et j'ai fini par laisser tomber. J'ouvrirai une issue sur https://github.com/Maks3w/SwaggerAssertions
En gros le problème est que quand il fait ces checks d'URL query, il prend une queryString, fait un parse_str , et se retrouve donc avec un array de strings. Puis il se plaint que ca match pas les types attendus...
There was a problem hiding this comment.
There was a problem hiding this comment.
Tu peux juste ajouter le lien vers l'issue dans le code ? Comme ça on pourra suivre l'évolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #11