Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize WOW64 in TouchFile custom action #553

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

robmen
Copy link
Member

@robmen robmen commented Jul 17, 2024

@robmen robmen requested a review from barnson July 17, 2024 18:10
@robmen
Copy link
Member Author

robmen commented Jul 17, 2024

WcaInitializeWow64() was a bit new to me, so I'm not sure this is the best way to use it. It felt like a real hassle given the way this code is structured so I'm open to suggestions if I misunderstood how WcaInitializeWow64() and friends were intended to be used.

@barnson
Copy link
Member

barnson commented Jul 17, 2024

I'm actually curious why this is needed. A 32-bit package can't touch the 64-bit file system so this would only be useful for touching a file installed by somebody else, no?

@robmen
Copy link
Member Author

robmen commented Jul 17, 2024

Yes. Touching a file outside of the MSI package.

Note: I've not run the test, so this could fail there. This was something simple I could throw together while recovering.

src/ext/Util/ca/TouchFile.cpp Show resolved Hide resolved
@robmen robmen enabled auto-merge (rebase) July 17, 2024 19:12
@robmen robmen merged commit 8fb5d57 into main Jul 17, 2024
2 checks passed
@robmen robmen deleted the robmen/8638-fix-touchfile branch July 17, 2024 19:15
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TouchFile fails due to 64-bit initialization
2 participants