Allow default major upgrade to be rescheduled.

Fixes wixtoolset/issues#8046.
wixtoolset · Mar 27, 2024 · 2b6fa3a · 2b6fa3a
1 parent 8db3616
commit 2b6fa3a
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 1 deletion.
diff --git a/src/wix/WixToolset.Core/Link/AddDefaultSymbolsCommand.cs b/src/wix/WixToolset.Core/Link/AddDefaultSymbolsCommand.cs
@@ -99,6 +99,7 @@ private void AddDefaultMajorUpgrade(WixPackageSymbol packageSymbol)
                     SequenceTable = SequenceTable.InstallExecuteSequence,
                     Action = "RemoveExistingProducts",
                     After = "InstallValidate",
+                    Overridable = true,
                 },
                 new WixSimpleReferenceSymbol(packageSymbol.SourceLineNumbers)
                 {
@@ -126,7 +127,10 @@ private void AddSymbols(IntermediateSection section, params IntermediateSymbol[]
                 {
                     var symbolWithSection = new SymbolWithSection(section, symbol);
                     var fullName = symbolWithSection.GetFullName();
-                    this.Find.SymbolsByName.Add(fullName, symbolWithSection);
+                    if (!this.Find.SymbolsByName.ContainsKey(fullName))
+                    {
+                        this.Find.SymbolsByName.Add(fullName, symbolWithSection);
+                    }
                 }
             }
         }

diff --git a/....CoreIntegration/TestData/DefaultMajorUpgradeReschedule/DefaultMajorUpgradeReschedule.wxs b/....CoreIntegration/TestData/DefaultMajorUpgradeReschedule/DefaultMajorUpgradeReschedule.wxs
@@ -0,0 +1,7 @@
+<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
+    <Package Name="DefaultMajorUpgradeReschedule" Language="1033" Version="2.0.0" Manufacturer="Example Corporation" UpgradeCode="{3F2494B1-AF5E-48ED-9C9E-843F1DB2BC97}">
+        <InstallExecuteSequence>
+            <RemoveExistingProducts After="InstallFinalize" />
+        </InstallExecuteSequence>
+    </Package>
+</Wix>
diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/UpgradeFixture.cs b/src/wix/test/WixToolsetTest.CoreIntegration/UpgradeFixture.cs
@@ -73,6 +73,20 @@ public void DefaultMajorUpgradePopulatesUpgradeRowsAsExpected()
             }, results);
         }
 
+        [Fact]
+        public void CanRescheduleRemoveExistingProductsWithDefaultMajorUpgrade()
+        {
+            var folder = TestData.Get("TestData", "DefaultMajorUpgradeReschedule");
+            var build = new Builder(folder, new Type[] { }, new[] { folder });
+
+            var results = build.BuildAndQuery(Build, "InstallExecuteSequence").Where(r => r.StartsWith("InstallExecuteSequence:RemoveExistingProducts") || r.StartsWith("InstallExecuteSequence:InstallFinalize")).ToArray();
+            WixAssert.CompareLineByLine(new[]
+            {
+                "InstallExecuteSequence:InstallFinalize\t\t6600",
+                "InstallExecuteSequence:RemoveExistingProducts\t\t6601",
+            }, results);
+        }
+
         [Fact]
         public void CanOverrideDefaultMajorUpgradeLaunchConditionMessage()
         {