Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): css-keyframes feature extraction #2215

Merged
merged 27 commits into from
Jan 2, 2022
Merged

refactor(core): css-keyframes feature extraction #2215

merged 27 commits into from
Jan 2, 2022

Commits on Dec 21, 2021

  1. empty css-keframes feature file to open the PR

    @idoros
    idoros committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    7494698 View commit details
    Browse the repository at this point in the history

  2. chore: prettify

    @idoros
    idoros committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    9490819 View commit details
    Browse the repository at this point in the history

  3. refactor(core): move related code into feature 

    - `KeyframeSymbol`
- `reservedKeyframes`
    @idoros
    idoros committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    9f76573 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2021

  1. refactor: move code from processor to feature 

    - analyze `@keyframes`
- default generic type to `createFeature` in case no specific nodes are required
    @idoros
    idoros committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    fb4bacf View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. chore: removed commented code

    @idoros
    idoros committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    8cbc176 View commit details
    Browse the repository at this point in the history

  2. refactor: register imported keyframes to st-symbol

    @idoros
    idoros committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    9ff4e2e View commit details
    Browse the repository at this point in the history

  3. refactor: move code from transformer to feature 

    - transform `@keyframes` at-rules
- transform `animation` and `ainmation-name` declarations
- export keyframes JS exports
- add new feature hooks: `transformResolve`, `transformAtRule`, `transformDeclaration`, and `transformJSExports`
- extract scope function to `helpers/namespace`
    @idoros
    idoros committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    c9cdab6 View commit details
    Browse the repository at this point in the history

  4. chore: removed refactored out code from resolver

    @idoros
    idoros committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    8bc0c8c View commit details
    Browse the repository at this point in the history

  5. chore: forgotton leftovers 

    - remove transformer commented code
- remove leftover `KeyframesSymbol` that was previously copied to `css-keyframes` feature
    @idoros
    idoros committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    f49df55 View commit details
    Browse the repository at this point in the history

  6. test: move related keyframes tests to feature spec

    @idoros
    idoros committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    1fe5530 View commit details
    Browse the repository at this point in the history

  7. test: format and add tests 

    - add test for `keframes` symbol collection
- add test for local override of imported symbol
- add `getKeyframesStatements()` to `css-keyframes` feature
    @idoros
    idoros committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    f54dedb View commit details
    Browse the repository at this point in the history

  8. refactor: use the same redeclare diagnostics as other symbols

    @idoros
    idoros committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    8a5c95d View commit details
    Browse the repository at this point in the history

  9. deprecate: keyframes meta fields 

    - no public api for any atm since the API should account for multiple definitions nested in `@media` at-rules
- `meta.keyframes` - internally `CSSKeyframes.get()`
- `meta.mappedKeyframes` - internally `CSSKeyframes.getKeyframesStatements()`
- new internal getter for all keyframes symbols - `CSSKeyframes.getAll()`
    @idoros
    idoros committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    e622de5 View commit details
    Browse the repository at this point in the history

  10. refactor: keyframes symbol import registration to css-keyframes fea… 

    …ture

- add static registration of typed imports by function (currently just for keyframes)
    @idoros
    idoros committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    20b05eb View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. fix: js-mixin keyframes to match current behavior 

    - `@keyframe st-global()` definition in mixin
- conflicted keyframes between mixin and stylesheet takes stylaesheet resolved definitions
- add ToDo for animation-name declaration from mixin symbols that cannot be resolved atm
    @idoros
    idoros committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    ed9e594 View commit details
    Browse the repository at this point in the history

  2. fix: keyframes symbols should not be inserted to depracated `mappedSy… 

    …mbols`
    @idoros
    idoros committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    6f9ef96 View commit details
    Browse the repository at this point in the history

  3. fix: report unresloved import keyframes diagnostic

    @idoros
    idoros committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    aeb44d2 View commit details
    Browse the repository at this point in the history

  4. test: add back mistakenly removed test

    @idoros
    idoros committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    d4b6874 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. chore: cleanup resolve import between namespaces

    @idoros
    idoros committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    18fe4e6 View commit details
    Browse the repository at this point in the history

  2. fix: allow keyframes redeclare under seperate scopes

    @idoros
    idoros committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    bd8685d View commit details
    Browse the repository at this point in the history

  3. fix: allow keyframes to be nested under root or @media

    @idoros
    idoros committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    ee3e6b5 View commit details
    Browse the repository at this point in the history

  4. fix: keyframe escaping

    @idoros
    idoros committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    3679bd7 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2022

  1. chore: removed escape of keyframes 

    leave as is for now to be solved consistently with other escaping issues
    @idoros
    idoros committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    336dcd3 View commit details
    Browse the repository at this point in the history

  2. chore: remove un-required import

    @idoros
    idoros committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    4aed373 View commit details
    Browse the repository at this point in the history

  3. feat: support @keyframes in @supports 

    - add `@supports` to `isInConditionalGroup`
    @idoros
    idoros committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    043c9b4 View commit details
    Browse the repository at this point in the history

  4. fix: global keyframes with no name symbol

    @idoros
    idoros committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    e77552b View commit details
    Browse the repository at this point in the history

  5. chore: small review changes 

    - add comment for `safeRedeclare` on keyframes symbols
- add comment about `st-import` feature `ImportTypeHook` static registration
- removed `escapeIdentifier` from `helpers/escape` for now
- changed all tests to use `@st-import` instead of `:import`
- test typo
    @idoros
    idoros committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    6b81954 View commit details
    Browse the repository at this point in the history