Reanimated and GestureHandler upgrade #3203
Conversation
…nt to GestureDetector component with gesture
Inbal-Tish
changed the title
There was a problem hiding this comment.
Marquee - iOS - horizontal not working (need to test on master)
TabController - both - no indicator (line beneath the selected tab item; need to test on master)
Slider - Android - performance is really bad (need to test on master)
ColorPickerScreen - both - need to wrap with <GestureHandlerRootView style={styles.container}> (remove the style from ScrollView)
PickerScreen - both - need to wrap with GestureHandlerRootView
PanView - both - drag does not work
Still did not go over everything
Marquee - doesn't work on master - works on a real device on both branches. |
| value.forEach((_, index) => { | ||
| value[index] = widths[index]; | ||
| }); | ||
| return value; |
There was a problem hiding this comment.
There's something a little confusing when you both update the value and return it.
Maybe use map instead of forEach and return it, it might even shorten this
There was a problem hiding this comment.
Tried it but it caused a TS error I could not find a fix for.
| value.forEach((_, index) => { | ||
| if (index > 0) { | ||
| value[index] = value[index - 1] + widths[index - 1]; | ||
| } | ||
| }); |
There was a problem hiding this comment.
same here, consider using map
There was a problem hiding this comment.
It appears that accessing value[index - 1] gives 0
This reverts commit a07caac.
Description
Reanimated and GestureHandler upgrade.
In preparation for the RN73 upgrade we need to upgrade Reanimated (from 3.4.0 to 3.8.1) and GestureHandler (from 2.9.0 to 2.14.1).
The upgrades involved some migrations:
Known issue - PanView gesture does not work on Android only.
Changelog
Upgrading Reanimated (3.8.1) and GestureHandler (2.14.1) + upgrade fixes
Additional info
ticket #4185