Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][iOS] Cleaning up initial notification after resolve #697

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

muryj
Copy link
Contributor

@muryj muryj commented Nov 4, 2020

There is a problem on iOS we encountered in RN application.
Steps to reproduce:

  • App is dead
  • Notification received (with deep link to some screen in app)
  • User opened the notification and navigated to some place in app
  • User performed some actions, which cause app to reload from scratch
  • App is loading from scratch ( initial notification is still there )
  • Notification handler takes the initial notification again
  • User navigated to some place in app again

Expected behaviour:
Initial notification should be cleared.

@muryj muryj requested a review from yogevbd as a code owner November 4, 2020 16:18
@muryj
Copy link
Contributor Author

muryj commented Nov 10, 2020

@yogevbd Can you take a look?

@yogevbd yogevbd merged commit d78e7a0 into wix:master Nov 11, 2020
mburmistrov pushed a commit to mburmistrov/react-native-notifications that referenced this pull request Jan 10, 2021
There is a problem on iOS we encountered in RN application. 
Steps to reproduce: 
- App is dead
- Notification received (with deep link to some screen in app) 
- User opened the notification and navigated to some place in app 
- User performed some actions, which cause app to reload from scratch 
- App is loading from scratch ( initial notification is still there )
- Notification handler takes the initial notification again 
- User navigated to some place in app again

Expected behaviour: 
Initial notification should be cleared. 

Co-authored-by: yevhenii <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants