Fix Xcode 12 Compatibility #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode 12 (released on Sept 16) fails to build without the module being liked to React-Core directly. This change is needed for React Native 0.60.2 or newer for iOS Ref: facebook/react-native#29633 (comment)
yogevbd
approved these changes
Sep 22, 2020
mburmistrov
pushed a commit
to mburmistrov/react-native-notifications
that referenced
this pull request
Jan 10, 2021
Xcode 12 (released on Sept 16) fails to build without the module being liked to React-Core directly. This change is needed for React Native 0.60.2 or newer for iOS Ref: facebook/react-native#29633 (comment) Co-authored-by: Yogev Ben David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 12 (released on Sept 16) fails to build without the module being liked to React-Core directly. This change is needed for React Native 0.60.2 or newer for iOS
Ref: facebook/react-native#29633 (comment)