[V2] Tweak app lifecycle docs #4877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyca
previously requested changes
Mar 19, 2019
|
Wonderful additions! Left one small comment :) |
guyca
approved these changes
Mar 21, 2019
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
* app launch docs consistent UI capitalisation * app launch docs greater detail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done two things here: first I have made the capitalisation of
UIconsistent; and a much greater change, I've expanded upon the android JS context vs android UI context documentation, including adding info for how to detect and handle a divergence of the lifecycle of the two contexts.If this is too verbose please let me know, I tried to balance a reasonable amount of text with leaving as little room for ambiguity as possible.
thanks for taking the time to review, and again for putting up these docs so quickly, I think it really will help folks take full advantage of this very comprehensive navigation solution!