[V2] Fix iOS pop gesture when topBar is hidden

[rawrmaan]

Fixes #4455.

The broken-ness of this feature stems from an iOS bug. I adapted the fix from this StackOverflow answer: https://stackoverflow.com/questions/24710258/no-swipe-back-when-hiding-navigation-bar-in-uinavigationcontroller/41895151#41895151 It seemed like the most well-thought-out and bulletproof fix out of all the answers.

I did thoroughly test this to make sure popGesture works with the nav bar hidden and visible, but I did not add any e2e tests. I would like some guidance on how to test something like this (a swipe gesture) if anyone could help, as I'm not very familiar with the XCTest framework.

Thanks for an amazing library! There really is nothing close out there!

[MasoudAlali]

I tested these changes and it works
I'm waiting for next release and I hope this problem will be fixed
thanks

[Rigellute]

Any updates on when this will be merged?

[mackiedrew]

I have been using this in production for weeks.

[LRNZ09]

This would be really useful

[tunegov]

Merge this, please!!!

[yashafromrussia]

@guyca hey, other than the conflicts, what are the requirements to have this merged? do we need tests for this? i dont see any rn, i can help out

[kyle-ssg]

This probably fixes two of my open issues, any reason why this is not merged? I don’t want to have to keep a big fork just to have fixes like this in

[Rigellute]

@rawrmaan thank you so much for doing this.

Do you have an idea for when this PR could be merged?

[mackiedrew]

@guyca What can we do to help the merge along?

[Rigellute]

Another way of fixing this would be to revert this change 11a174b

The bug that this change was fixing Fix popGesture freezes the app can be worked around by doing this in your root component

componentDidAppear() {
    Navigation.mergeOptions(this.props.componentId, {
        popGesture: false,
    });
}

componentDidDisappear() {
    Navigation.mergeOptions(this.props.componentId, {
        popGesture: true,
    });
}

[moonou]

I like this PR, I upgrade version to 2.14.0-snapshot.246 for the pop gesture, but when I use gesture to pop page, I found registerCommandListener wasn't called. Does anybody have some idea for this?

[guyca]

@moonou the command listener is invoked only when Navigation.pop command is invoked.

[dangkhoa2708]

Navigation.push(this.currentScreen, { component: { id: screenID, name: screenID, passProps: params, options: { popGesture: true, bottomTabs: { visible: false, drawBehind: true }, statusBar: { backgroundColor: 'white' }, animations: { push: { content: { x: { from: 1000, to: 0, duration: 250 } } }, pop: { content: { x: { from: 0, to: 1000, duration: 250 } } } } } } })

First of all, thank you for this awesome library, I ran into the pop gesture issue when the top bar is hidden. I've been following this issue from when it was not merged until now. But I still can not make it work. Am I doing it wrong ? Very appreciated with any help.

I'm using version 2.16