[v2] add support for react-native 0.57.0 #3851

alradadi · 2018-08-24T23:32:26Z

No description provided.

manosim · 2018-09-12T23:20:58Z

Can confirm that this works great on a fresh RN 0.57.0 project.

I had to use Step 9 from the (installation guide) which I guess is not optional any more?

Basically I had to add:

configurations.all {
    resolutionStrategy.eachDependency { DependencyResolveDetails details ->
        def requested = details.requested
        if (requested.group == 'com.android.support' && requested.name != 'multidex') {
            details.useVersion "${rootProject.ext.supportLibVersion}"
        }
    }
}

but NOT this implementation 'com.android.support:design:25.4.0'.

In android/build.gradle, I only had to bump the minSdkVersion since RN 0.57 comes with updated versions of buildToolsVersion & supportLibVersion etc.

esipavicius · 2018-09-16T21:45:12Z

So what I need to do to run react-native-navigation v2 with react-native 57? I geting:

error: cannot find symbol
import com.facebook.react.uimanager.UIImplementationProvider;
...

or if add "|| names.contains("reactNative56")"
does not exist
import com.reactnativenavigation.NavigationActivity;
....

I need to wait for release?

holparb · 2018-09-17T09:43:34Z

Can someone who feels confident in the topic please review the PR and accept if it's okay?
We would love to have RNN with RN 0.57 support. :)

DVSoftware · 2018-09-18T15:54:38Z

Doesn't work with latest:

/Users/dvsoftware/Projects/-/node_modules/react-native-navigation/lib/android/app/src/reactNative57/java/com/reactnativenavigation/react/NavigationReactNativeHost.java:24: error: duplicate class: com.reactnativenavigation.react.NavigationReactNativeHost
public class NavigationReactNativeHost extends ReactNativeHost implements BundleDownloadListenerProvider {
       ^
/Users/dvsoftware/Projects/-/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationReactNativeHost.java:86: error: cannot find symbol
                .setUIImplementationProvider(getUIImplementationProvider())
                                             ^
  symbol:   method getUIImplementationProvider()
  location: class NavigationReactNativeHost

LeVadim · 2018-09-18T22:01:37Z

Any update on this? Looking forward to it.
Thank you

leonardoballand · 2018-09-18T22:07:42Z

I've created a repository that is working, while the PR is waiting to be merged.

https://github.com/leonardoballand/react-native-navigation-rn57

Just need to do:
yarn add https://github.com/leonardoballand/react-native-navigation-rn57.git

Hope it helps

alradadi · 2018-09-18T22:19:01Z

@esipavicius @DVSoftware this hasn't been merged so you can't use it just yet. We're waiting on someone to review this and accept it. @guyca would you please review this so these beautiful people can use navigation with the new react 0.57?

LeVadim · 2018-09-18T22:22:52Z

Would appreciate if it would be possible to merge this change, thank you!!

ammichael · 2018-09-18T23:28:36Z

@guyca sorry bother (once more), but with iOS 12 release, RN 0.57 is almost mandatory since it fixes tons of XCode 10 problems. Could you please review and merge this PR?

Thanks a lot!

DVSoftware · 2018-09-19T08:31:04Z

@esipavicius @DVSoftware this hasn't been merged so you can't use it just yet. We're waiting on someone to review this and accept it. @guyca would you please review this so these beautiful people can use navigation with the new react 0.57?

I know, i applied the patch, but i'm getting the mentioned errors

epileftro85 · 2018-09-20T17:13:15Z

is this available now?

djedlajn · 2018-09-21T09:21:13Z

Would be great if this gets merged

esipavicius · 2018-09-21T10:51:55Z

Would be great if this gets merged

But it has red light. Everywhere is red ;D

urosappdev · 2018-09-21T10:57:31Z

Works on fresh 0.57 i don’t know why is it failing.

…

On Fri, 21 Sep 2018 at 12:52, Ernestas Sipavičius ***@***.***> wrote: Would be great if this gets merged But it has red light. Everywhere is red ;D — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3851 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ans8fDFUsSXBFqsAYEcqorgAWjBiwLjbks5udMT0gaJpZM4WMIMn> .

ujwal-setlur · 2018-09-21T18:42:20Z

I applied the patch to my project. Does not work:

> Task :react-native-navigation:compileReactNative57DebugJavaWithJavac FAILED
/Users/ujwal/Work/seamlz/seamlz-mobile/node_modules/react-native-navigation/lib/android/app/src/reactNative57/java/com/reactnativenavigation/react/NavigationReactNativeHost.java:24: error: duplicate class: com.reactnativenavigation.react.NavigationReactNativeHost
public class NavigationReactNativeHost extends ReactNativeHost implements BundleDownloadListenerProvider {
       ^
/Users/ujwal/Work/seamlz/seamlz-mobile/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationReactNativeHost.java:86: error: cannot find symbol
                .setUIImplementationProvider(getUIImplementationProvider())
                                             ^
  symbol:   method getUIImplementationProvider()
  location: class NavigationReactNativeHost
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
2 errors

ammichael · 2018-09-21T18:57:26Z

@ujwal-setlur did you remember to filter the RN56 variant on build.gradle?

ujwal-setlur · 2018-09-21T19:00:53Z

@ammichael filter? How? Here is my build.gradle:

    defaultConfig {
        applicationId "com.seamlz.app"
        minSdkVersion rootProject.ext.minSdkVersion
        targetSdkVersion rootProject.ext.targetSdkVersion
        missingDimensionStrategy "RNN.reactNativeVersion", "reactNative57"
        versionCode buildNumber
        versionName "${versionMajor}.${versionMinor}.${versionPatch}"
        ndk {
            abiFilters "armeabi-v7a", "x86"
        }
    }

ujwal-setlur · 2018-09-21T19:02:59Z

Essentially, I am running into the same issue as @DVSoftware

ammichael · 2018-09-21T19:04:31Z

@ujwal-setlur try adding this to your /android/build.gradle:

subprojects { subproject ->
    afterEvaluate {
        if ((subproject.plugins.hasPlugin("android") || subproject.plugins.hasPlugin("android-library"))) {
            android {
                compileSdkVersion rootProject.ext.compileSdkVersion
                buildToolsVersion rootProject.ext.buildToolsVersion
                // Ignoring RN Navigation Flavors. Needs to be updated when lib is updated
                variantFilter { variant ->
                  def names = variant.flavors*.name
                  if (names.contains("reactNative51") || names.contains("reactNative55") || names.contains("reactNative56")) {
                      setIgnore(true)
                  }
                }
            }
        }
    }
}

ujwal-setlur · 2018-09-21T19:16:52Z

@ammichael unfortunately, I still get that error...

It seems not so much of a conflict between reactNative57 and reactNative56, but more between reactNative57 and the code under src/main/java/com/reactnativenavigation/react/NavigationReactNativeHost.java

They both declare NavigationReactNativeHost class

mcousillas6 · 2018-09-24T15:56:43Z

Hi guys, Any news about this?

ammichael · 2018-09-26T21:55:49Z

This has been opened more than 1 month ago. I'm in a really bad situation here; can't update to RN 0.57 and release my iOS 12 update while this isn't merged. It's very likely there are more people in the same situation. Please, can somebody (@guyca) take over this merge, fix what is failing and finally merge it?!

Please?

ujwal-setlur · 2018-09-26T23:49:06Z

Yes me too please. Frankly, I am contemplating moving off RNN. Issues with RN releases, issues with code push. I really like this library, but it's getting hard...

guyca · 2018-10-11T06:38:01Z

Hey guys, sorry for the delay

PR looks good, though it seems that RNN isn't compatible with RN 0.57. The workaround pruposed here broke, I think RNN is pretty much unusable in large apps without this fix 😕

// for future guyca

{
  "react": "16.5.1",
  "react-native": "0.57.1"
}

exec.execSync(node ./node_modules/react-native/local-cli/cli.js start --projectRoot ./playground/);

alradadi · 2018-10-12T07:16:43Z

Thanks for merging @guyca, but what do you mean RNN isn't compatible with react-native 0.57 :D?
I've been using it with 0.57.2 and it's working for me.

retyui · 2018-10-12T07:23:26Z

@abdullah-sr It is working on IOS or Android ?

leonardoballand · 2018-10-12T07:24:51Z

Both for me

alradadi · 2018-10-12T07:25:13Z

@retyui both iOS and android

Coding-2-86 · 2018-10-12T07:27:10Z

@abdullah-sr what's your rn & rnn version?

alradadi · 2018-10-12T07:30:14Z

well i was using my own fork with react-native 0.57.2, but since this was merged you can use the last release that came out yesterday 2.0.2580

sampettersson · 2018-10-12T07:52:54Z

@abdullah-sr RNN requires a custom synchronous UIImplementationProvider, Facebook refactored those bits for 0.57 meaning you can't pass a custom UIImplementationProvider anymore. So for large-ish apps, RNN just throws weird errors all the time :/

alradadi · 2018-10-12T07:56:55Z

i see. well luckily I haven't run into those issues yet.

guyca · 2018-10-14T12:47:28Z

@Iamsamwhoami I think I have a workaround for that, hope to publish it in the net few days. Also spoke to some guys at facebook and they reintroduce the api we require.

guyca · 2018-10-18T07:15:30Z

Quick update, there's an internal PR at RN which reintroduces the UiImplementation api we need. If all goes well it should land in RN 0.58.
If you're extensively using react components in TopBar - I suggest you reconsider upgrading to RN 0.57.

Dgs-asohail4 · 2018-10-18T19:29:09Z

Just tried migrating my RN 0.57 project from V1 to V2 got this error
D:\Projects\React\React-Native Sample app\MobileApp\node_modules\react-native-navigation\lib\android\app\src\reactNative56\java\com\reactnativenavigation\react\SyncUiImplementation.java:10: error: cannot find symbol
import com.facebook.react.uimanager.UIImplementationProvider;
^
symbol: class UIImplementationProvider
location: package com.facebook.react.uimanager
D:\Projects\React\React-Native Sample app\MobileApp\node_modules\react-native-navigation\lib\android\app\src\reactNative56\java\com\reactnativenavigation\react\SyncUiImplementation.java:23: error: cannot find symbol
public static class Provider extends UIImplementationProvider {
^
symbol: class UIImplementationProvider
location: class SyncUiImplementation
D:\Projects\React\React-Native Sample app\MobileApp\node_modules\react-native-navigation\lib\android\app\src\reactNative56\java\com\reactnativenavigation\react\NavigationReactNativeHost.java:86: error: cannot find symbol
.setUIImplementationProvider(getUIImplementationProvider())
^
symbol: method getUIImplementationProvider()
location: class NavigationReactNativeHost
D:\Projects\React\React-Native Sample app\MobileApp\node_modules\react-native-navigation\lib\android\app\src\reactNative56\java\com\reactnativenavigation\react\SyncUiImplementation.java:24: error: method does not override or implement a method from a supertype
@OverRide
^
D:\Projects\React\React-Native Sample app\MobileApp\node_modules\react-native-navigation\lib\android\app\src\reactNative56\java\com\reactnativenavigation\react\SyncUiImplementation.java:29: error: method does not override or implement a method from a supertype
@OverRide
^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
5 errors

RNN version 2.0.595

esipavicius · 2018-10-18T20:58:23Z

Just tried migrating my RN 0.57 project from V1 to V2 got this error
D:\Projects\React\React-Native Sample app\MobileApp\node_modules\react-native-navigation\lib\android\app\src\reactNative56\java\com\reactnativenavigation\react\SyncUiImplementation.java:10: error: cannot find symbol
import com.facebook.react.uimanager.UIImplementationProvider;
^
symbol: class UIImplementationProvider
location: package com.facebook.react.uimanager
D:\Projects\React\React-Native Sample app\MobileApp\node_modules\react-native-navigation\lib\android\app\src\reactNative56\java\com\reactnativenavigation\react\SyncUiImplementation.java:23: error: cannot find symbol
public static class Provider extends UIImplementationProvider {
^
symbol: class UIImplementationProvider
location: class SyncUiImplementation
D:\Projects\React\React-Native Sample app\MobileApp\node_modules\react-native-navigation\lib\android\app\src\reactNative56\java\com\reactnativenavigation\react\NavigationReactNativeHost.java:86: error: cannot find symbol
.setUIImplementationProvider(getUIImplementationProvider())
^
symbol: method getUIImplementationProvider()
location: class NavigationReactNativeHost
D:\Projects\React\React-Native Sample app\MobileApp\node_modules\react-native-navigation\lib\android\app\src\reactNative56\java\com\reactnativenavigation\react\SyncUiImplementation.java:24: error: method does not override or implement a method from a supertype
@OverRide
^
D:\Projects\React\React-Native Sample app\MobileApp\node_modules\react-native-navigation\lib\android\app\src\reactNative56\java\com\reactnativenavigation\react\SyncUiImplementation.java:29: error: method does not override or implement a method from a supertype
@OverRide
^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
5 errors

RNN version 2.0.595

Maybe its it: https://github.com/invertase/react-native-firebase-docs/pull/133/files
I created pull request to documentation. Please try it and write if its works. I already have working project :)

Dgs-asohail4 · 2018-10-19T07:35:11Z

@esipavicius thanks i got it working now

See wix/react-native-navigation#3851

ghost · 2018-11-13T15:54:18Z

> Task :react-native-navigation:compileReactNative57WixForkReleaseJavaWithJavac FAILED

margaridaDinis · 2018-11-19T10:47:30Z

I'm getting Execution failed for task ':react-native-navigation:compileReactNative57WixForkReleaseJavaWithJavac'. when I run ./gradlew assembleRelease.

It works on development builds for both Android and iOs, and release for iOs...

I have
React Native 0.57.0,
React 16.5.0
React Native Navigation 2.1.2

diegolmello · 2018-11-19T10:55:26Z

@margaridaDinis It seems you need to ignore 57 Wix.
https://wix.github.io/react-native-navigation/#/docs/Installing?id=_82-ignore-other-rnn-flavors

subprojects { subproject ->
    afterEvaluate {
        if ((subproject.plugins.hasPlugin('android') || subproject.plugins.hasPlugin('android-library'))) {
            android {
                variantFilter { variant ->
                    def names = variant.flavors*.name
                    if (names.contains("reactNative51") || names.contains("reactNative55") || names.contains("reactNative56") || names.contains("reactNative57WixFork")) {
                        setIgnore(true)
                    }
                }
            }
        }
    }
}

margaridaDinis · 2018-11-19T11:04:41Z

That fixed it! The build is now succeeding, thanks @diegolmello

Haqverdi · 2018-11-28T06:02:13Z

Hello
I have such a problem with the React version 0.57.6
error:

What went wrong:
Execution failed for task ': app: transformDexArchiveWithExternalLibsDexMergerForDebug'.

java.lang.RuntimeException: java.lang.RuntimeException: com.android.builder.dexing.DexArchiveMergerException: Unable to merge dex

someone had a similar problem???

Haqverdi · 2018-11-28T06:22:25Z

Hello
I have such a problem with the React version 0.57.6
error:

What went wrong:
Execution failed for task ': app: transformDexArchiveWithExternalLibsDexMergerForDebug'.

java.lang.RuntimeException: java.lang.RuntimeException: com.android.builder.dexing.DexArchiveMergerException: Unable to merge dex

someone had a similar problem???

i soled problems, but dont know correctly how)))))

hisothreed · 2018-12-26T11:49:19Z

@Haqverdi

solved by adding those to app/build.gradle

defaultConfig {
       ...
        missingDimensionStrategy "RNN.reactNativeVersion", "reactNative57_5"
       ...
}

dependencies {
implementation fileTree(dir: "libs", include: ["*.jar"])
implementation "com.android.support:design:${rootProject.ext.supportLibVersion}"
implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"
implementation "com.android.support:support-v4:${rootProject.ext.supportLibVersion}"

implementation "com.facebook.react:react-native:+"  // From node_modules
implementation project(':react-native-navigation')

}

NweThazin · 2019-01-25T09:52:24Z

Hi,

Which RNN version should I update to support react native 0.57.0?
thanks

Haqverdi · 2019-01-26T16:58:02Z

Hi,

Which RNN version should I update to support react native 0.57.0?
thanks

latest works good)

add support for react-native 0.57.0

fe6db48

alradadi changed the title ~~add support for react-native 0.57.0~~ [v2] add support for react-native 0.57.0 Aug 25, 2018

ItsNoHax mentioned this pull request Sep 17, 2018

[V2] RNN and React Native version #3975

Closed

Merge branch 'v2' into v2

fe2c506

makirby mentioned this pull request Sep 20, 2018

Error with react native navigation on new react-native-0.57.0 #3996

Closed

Merge branch 'v2' into v2

8d5aeb6

Merge branch 'v2' into v2

8d8a85b

guyca approved these changes Oct 11, 2018

View reviewed changes

guyca merged commit ab2f335 into wix:v2 Oct 11, 2018

juddey mentioned this pull request Nov 5, 2018

Does not seem to work with RN 0.56 juddey/ignite-react-native-navigation#5

Open

markymc added a commit to TacchiStudios/react-native that referenced this pull request Nov 13, 2018

revert facebook@506f920 in order to work with RNN 2

be08174

See wix/react-native-navigation#3851

tigo0 mentioned this pull request Nov 15, 2018

document supported versions of react native #4320

Closed

rajivshah3 pushed a commit to rajivshah3/react-native-navigation that referenced this pull request Nov 21, 2018

add support for react-native 0.57.0 (wix#3851)

444a4fc

thame pushed a commit to thame/react-native-navigation that referenced this pull request Jan 16, 2019

add support for react-native 0.57.0 (wix#3851)

dbe6ce1

[v2] add support for react-native 0.57.0 #3851

[v2] add support for react-native 0.57.0 #3851

Conversation

alradadi commented Aug 24, 2018

manosim commented Sep 12, 2018

esipavicius commented Sep 16, 2018

holparb commented Sep 17, 2018

DVSoftware commented Sep 18, 2018

LeVadim commented Sep 18, 2018

leonardoballand commented Sep 18, 2018 • edited Loading

alradadi commented Sep 18, 2018

LeVadim commented Sep 18, 2018

ammichael commented Sep 18, 2018

DVSoftware commented Sep 19, 2018

epileftro85 commented Sep 20, 2018

djedlajn commented Sep 21, 2018

esipavicius commented Sep 21, 2018

urosappdev commented Sep 21, 2018 via email

ujwal-setlur commented Sep 21, 2018

ammichael commented Sep 21, 2018

ujwal-setlur commented Sep 21, 2018

ujwal-setlur commented Sep 21, 2018

ammichael commented Sep 21, 2018

ujwal-setlur commented Sep 21, 2018

mcousillas6 commented Sep 24, 2018

ammichael commented Sep 26, 2018

ujwal-setlur commented Sep 26, 2018

guyca commented Oct 11, 2018

alradadi commented Oct 12, 2018

retyui commented Oct 12, 2018

leonardoballand commented Oct 12, 2018

alradadi commented Oct 12, 2018

Coding-2-86 commented Oct 12, 2018

alradadi commented Oct 12, 2018

sampettersson commented Oct 12, 2018

alradadi commented Oct 12, 2018

guyca commented Oct 14, 2018

guyca commented Oct 18, 2018

Dgs-asohail4 commented Oct 18, 2018

esipavicius commented Oct 18, 2018

Dgs-asohail4 commented Oct 19, 2018

ghost commented Nov 13, 2018

margaridaDinis commented Nov 19, 2018

diegolmello commented Nov 19, 2018

margaridaDinis commented Nov 19, 2018

Haqverdi commented Nov 28, 2018

Haqverdi commented Nov 28, 2018

hisothreed commented Dec 26, 2018

NweThazin commented Jan 25, 2019

Haqverdi commented Jan 26, 2019

leonardoballand commented Sep 18, 2018 •

edited

Loading