Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1][Android] react-native v.0.57 compatibility / remove deprecated UIImplementationProvider #3836

Merged
merged 2 commits into from
Aug 30, 2018

Conversation

johakr
Copy link
Contributor

@johakr johakr commented Aug 23, 2018

com.facebook.react.uimanager.UIImplementationProvider has been removed as of [email protected] (commit), breaking react-native-navigation v1 on android.

Hence removing the usage of UIImplementationProvider in react-native-navigation.

I know, all your efforts are on v2 already, but it would be great not to see v1 compatibility with react-native break too soon. :)

Update Jenkins build status badge
@guyca guyca merged commit 22b3b40 into wix:master Aug 30, 2018
reimertz pushed a commit to mavencook/react-native-navigation that referenced this pull request Sep 14, 2018
@varungupta85
Copy link
Contributor

@guyca Can we revert this merge now that we can provide the UIImplementationProvider again?

@guyca
Copy link
Collaborator

guyca commented Jan 9, 2019

Hey 👋
It's already reverted, use missingDimensionStrategy "RNN.reactNativeVersion", "reactNative57_5" in build.gradle

nathanielram pushed a commit to Osedea/react-native-navigation that referenced this pull request Feb 11, 2019
@rotarsebastian
Copy link

Is there any way I could use the last version of react-native with the v1 react-native-navigation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants