Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] topBar Button icon not show in iOS10 #4759

Closed
trungthanhnt opened this issue Feb 19, 2019 · 1 comment
Closed

[V2] topBar Button icon not show in iOS10 #4759

trungthanhnt opened this issue Feb 19, 2019 · 1 comment

Comments

@trungthanhnt
Copy link

trungthanhnt commented Feb 19, 2019

Issue Description

My topBar button icon is not shown on iOS 10.3.3 iPhone 5S. ( However In iPhone 7 12.x.x it works)
Please show me how to fix it.
Thank you very much

Steps to Reproduce / Code Snippets / Screenshots

static get options() {
return {
topBar: {

    title: {
      text: 'ChatScreen',

    },

    leftButtons: [
     
      {
        id: 'searchBttn',
        icon: require('../../resources/images/ic_search_blue.png'),
  
        text:'QR Chat',
       
        disableIconTint:true,
      },
      
    ],
    background: {
      color: '#fff'
    },
    noBorder: true,
    elevation: 0,
  }
};

}

Environment

  • React Native Navigation version: 2.12.0
  • React Native version: 0.57.1
  • Platform(s) (iOS, Android, or both?): iOS 10.3.3
  • Device info (Simulator/Device? OS version? Debug/Release?): Device iPhone 5S Debug and Release
@varungupta85
Copy link
Contributor

I am observing similar problem. This is a problem introduced after version 2.8.0 as the images appear fine in that version but don't show after I updated to 2.12.0. This is of course not reproducible in an e2e test because they only run on the latest iOS on which the problem is not seen.

@guyca @yogevbd

yogevbd added a commit that referenced this issue Feb 25, 2019
@guyca guyca closed this as completed in 8282d93 Feb 26, 2019
vshkl pushed a commit to vshkl/react-native-navigation that referenced this issue Feb 5, 2020
Fix top bar buttons size on iOS 10

Fixes wix#4759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants