Skip to content

Commit

Permalink
Prevent keyboard from hiding when overlay is shown (#4778)
Browse files Browse the repository at this point in the history
If you use overlays to show in-app notifications
it would closes the keyboard every time an overlay is
opened.
  • Loading branch information
tomhicks authored and yogevbd committed Feb 26, 2019
1 parent 8282d93 commit aba58b6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/ios/RNNOverlayManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ - (void)showOverlayWindow:(RNNOverlayWindow *)overlayWindow {
[_overlayWindows addObject:overlayWindow];
overlayWindow.rootViewController.view.backgroundColor = [UIColor clearColor];
[overlayWindow setWindowLevel:UIWindowLevelNormal];
[overlayWindow makeKeyAndVisible];
[overlayWindow setHidden: NO];
}

- (void)dismissOverlay:(UIViewController*)viewController {
Expand Down

1 comment on commit aba58b6

@ItsNoHax
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yogevbd @guyca Pretty sure this commit is causing weird behaviour. Any sort of textinputs in iOS are no longer focusing properly.

Going to create an issue.

Please sign in to comment.