remove usage of ViewPropTypes #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bananer
force-pushed
the
remove_viewproptypes
branch
2 times, most recently
from
53391b5 to
98ff71a
Compare
viniciuspetrachin
approved these changes
Mar 2, 2021
stackhousesrl
approved these changes
Apr 10, 2021
Inbal-Tish
reviewed
Apr 19, 2021
viniciuspetrachin
approved these changes
Apr 19, 2021
bananer
force-pushed
the
remove_viewproptypes
branch
from
98ff71a to
bfb7bbd
Compare
Inbal-Tish
approved these changes
Apr 20, 2021
This was referenced Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewPropTypesare deprecated inreact-native( react-native-community/discussions-and-proposals#29 , react-native-community/discussions-and-proposals#29 ) and were already removed fromreact-native-web.Supposedly #1236 should fix building with
react-native-web12+, however that did not work for me and many others (see #1033). I'm still getting the error"Attempted import error: 'ViewPropTypes' is not exported from 'react-native' (imported as 'ReactNative')."It seems to me that the usage of
ViewPropTypesdoes not add a lot of value anyways, the generic types likePropTypes.objectfrom theprop-typespackage are used for most type definitions inCalendarandAgenda.Therefore, i propose removing the reliance on
ViewPropTypesfor the only two cases where it was used. This should make the package compatible withreact-native-webtoday and a future version ofreact-nativewithViewPropTypesremoved.