Improved android build scripts #4638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4vidi
reviewed
Nov 24, 2024
| if (file.exists()) { | ||
| return file.path | ||
| } | ||
| currentDir = currentDir.parentFile |
There was a problem hiding this comment.
Will this continue all the way up to the filesystem's root? I think we should stop at the root project's dir 🤔
There was a problem hiding this comment.
We don't know who is the root. It could be in any structure of projects in mono repo. It is logn. not so bad
There was a problem hiding this comment.
Yeah I didn't have performance in mind when I wrote this, rather possible resolutions of wrong node module folders or attempting access to non-priviledged directories (think CI agents).
Anyways, smt to think abt but might be an overkill.
d4vidi
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I have improved the android build script in order to be sure it could work in any project structure