Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid duplicated declaration error on xml generation. #4615

Merged
merged 4 commits into from
Oct 19, 2024

Conversation

asafkorem
Copy link
Contributor

Fixing a JS error when injecting JS to webviews to generate XML view hierarchy.
The declarations are now made inside the injected JS function and not on the higher scope.

…ation.

Fixing error when injecting JS to webviews to generate XML view hierarchy.
The declarations are now made inside the injected JS function and not on
 the higher scope.
@asafkorem asafkorem self-assigned this Oct 19, 2024
@asafkorem asafkorem changed the title fix(iOS): avoid duplicated declaration error on consecutive xml generation. fix: avoid duplicated declaration error on consecutive xml generation. Oct 19, 2024
@asafkorem asafkorem changed the title fix: avoid duplicated declaration error on consecutive xml generation. fix: avoid duplicated declaration error on xml generation. Oct 19, 2024
@asafkorem asafkorem merged commit f97c747 into master Oct 19, 2024
3 checks passed
@asafkorem asafkorem deleted the fix/view-hierarchy-ios branch October 19, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant