Skip to content

Commit

Permalink
Revert "Make the scala_protobuf aspect based (bazelbuild#700)"
Browse files Browse the repository at this point in the history
This reverts commit 74192b2.
  • Loading branch information
ittaiz committed Mar 21, 2019
1 parent a7c85f0 commit c9dc02f
Show file tree
Hide file tree
Showing 18 changed files with 605 additions and 938 deletions.
6 changes: 4 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ env:
# See https://github.com/bazelbuild/rules_scala/pull/622
# we want to test the last release
#- V=0.16.1 TEST_SCRIPT=test_lint.sh
- V=0.23.1 TEST_SCRIPT=test_rules_scala.sh
- V=0.17.1 TEST_SCRIPT=test_rules_scala.sh
- V=0.22.0 TEST_SCRIPT=test_rules_scala.sh
#- V=0.14.1 TEST_SCRIPT=test_intellij_aspect.sh
- V=0.23.1 TEST_SCRIPT=test_reproducibility.sh
- V=0.17.1 TEST_SCRIPT=test_reproducibility.sh
- V=0.22.0 TEST_SCRIPT=test_reproducibility.sh

before_install:
- |
Expand Down
8 changes: 3 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,9 @@ for an example workspace using another scala version.

## Bazel compatible versions

| bazel | rules_scala gitsha |
|--------|--------------------|
| 0.23.x | HEAD |
| 0.22.x | f3113fb6e9e35cb8f441d2305542026d98afc0a2 |
| 0.16.x | f3113fb6e9e35cb8f441d2305542026d98afc0a2 |
| bazel | rules_scala gitsha |
|-------|--------------------|
| 0.16.x | HEAD |
| 0.15.x | 3b9ab9be31ac217d3337c709cb6bfeb89c8dcbb1 |
| 0.14.x | 3b9ab9be31ac217d3337c709cb6bfeb89c8dcbb1 |
| 0.13.x | 3c987b6ae8a453886759b132f1572c0efca2eca2 |
Expand Down
4 changes: 0 additions & 4 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,6 @@ load("@io_bazel_rules_scala//scala:toolchains.bzl", "scala_register_unused_deps_

scala_register_unused_deps_toolchains()


register_toolchains("@io_bazel_rules_scala//test/proto:scalapb_toolchain")


load("//scala:scala_maven_import_external.bzl", "scala_maven_import_external", "java_import_external")

scala_maven_import_external(
Expand Down
38 changes: 0 additions & 38 deletions scala_proto/BUILD
Original file line number Diff line number Diff line change
@@ -1,38 +0,0 @@
load("//scala_proto:scala_proto_toolchain.bzl", "scala_proto_toolchain")

toolchain_type(
name = "toolchain_type",
visibility = ["//visibility:public"],
)

scala_proto_toolchain(
name = "default_toolchain_impl",
with_grpc = True,
with_flat_package=False,
with_single_line_to_string=False,
visibility = ["//visibility:public"],
)

toolchain(
name = "default_toolchain",
toolchain = ":default_toolchain_impl",
toolchain_type = "@io_bazel_rules_scala//scala_proto:toolchain_type",
visibility = ["//visibility:public"],
)


scala_proto_toolchain(
name = "enable_all_options_toolchain_impl",
with_grpc = True,
with_flat_package=True,
# with_java=True,
with_single_line_to_string=True,
visibility = ["//visibility:public"],
)

toolchain(
name = "enable_all_options_toolchain",
toolchain = ":enable_all_options_toolchain_impl",
toolchain_type = "@io_bazel_rules_scala//scala_proto:toolchain_type",
visibility = ["//visibility:public"],
)
Empty file removed scala_proto/private/BUILD
Empty file.
31 changes: 0 additions & 31 deletions scala_proto/private/dep_sets.bzl

This file was deleted.

49 changes: 0 additions & 49 deletions scala_proto/private/proto_to_scala_src.bzl

This file was deleted.

Loading

0 comments on commit c9dc02f

Please sign in to comment.