Register custom transitioning delegates for modal presentation #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 24, 2016 11:24
…ed to delegateIds in the RCCManager. In the passProps of the call to show the modal controller, pass in the transitioningDelegateId.
|
Hi, we wanted to update you that we are currently postponing the processing of pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for custom modal transitioning delegates to be registered in the
RCCManager.In the
passPropsof the call to show the modal controller, pass in atransitioningDelegateIdpreviously registered on theRCCManager. Additionally, make sureanimationTypeis passed in as'custom'.This transitioningDelegate is then applied as the
UIViewController.transitioningDelegateand itsmodalPresentationStyleis set toUIModalPresentationCustom.