fix(net): prevent panicking when finding an unknown HTTP status code #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @guidiaz for discovering this security bug! 💪 |
aesedepece
added
bug 🐜
aesedepece
force-pushed
the
fix/net/http-status-codes
branch
2 times, most recently
from
2674a40
to
6a0528a
Compare
Tommytrg
reviewed
Sep 20, 2023
| let mut res = surf::http::Response::new(status); | ||
| let code = status.status.as_u16(); | ||
| let mut res = | ||
| std::panic::catch_unwind(|| surf::http::Response::new(status)).map_err(|_| { |
There was a problem hiding this comment.
Could we add a comment explaining that we need to use catch_unwind because the surf library panics instead of returning a Result?
Tommytrg
approved these changes
Sep 21, 2023
aesedepece
force-pushed
the
fix/net/http-status-codes
branch
from
6a0528a
to
672e22d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a potential DoS attack to where witnessing nodes could be forced into a temporal desynchronization state and slashing could be triggered on them on purpose.