chore: fix clippy warnings for rust 1.49 #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpolaczyk
force-pushed
the
rust-1-49
branch
from
c2f169f
to
897aa85
Compare
lrubiorod
reviewed
Dec 23, 2020
bridges/ethereum/src/eth.rs
Outdated
| @@ -1,6 +1,6 @@ | |||
| use crate::config::Config; | |||
| use crate::multibimap::MultiBiMap; | |||
lrubiorod
reviewed
Dec 23, 2020
node/src/actors/chain_manager/mod.rs
Outdated
| @@ -1736,7 +1698,7 @@ impl ChainManager { | |||
| // Return all the blocks from this epoch range | |||
| let hashes: Vec<(Epoch, Hash)> = block_chain_range.collect(); | |||
|
|
|||
| Ok(hashes) | |||
| hashes | |||
There was a problem hiding this comment.
Could you remove the let hashes? Or the collect forces you to use it?
lrubiorod
reviewed
Dec 23, 2020
| @@ -1837,7 +1793,10 @@ impl ChainManager { | |||
|
|
|||
| actix::fut::ok(()) | |||
| }) | |||
| .map_err(|e, _, _| log::error!("{:?}", e)); | |||
| .map_err(|(), _, _| { | |||
| // Errors at this point should be impossible because we explicitly ignore them | |||
There was a problem hiding this comment.
if it is impossible, should we put a panic?
There was a problem hiding this comment.
I think we can also remove that map_err, but I will put a panic so we can find any potential errors.
tmpolaczyk
force-pushed
the
rust-1-49
branch
4 times, most recently
from
4c681b9
to
62b3fb8
Compare
aesedepece
approved these changes
Dec 31, 2020
tmpolaczyk
force-pushed
the
rust-1-49
branch
from
62b3fb8
to
efa1727
Compare
|
Disabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
cargo +nightly clippy --alland fix all the warnings. The Rust 1.49 update is scheduled for December 31st, but this PR can be merged now.These are the new lints fixed by this PR:
https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps