Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add BOBA price feeds #58

Merged
merged 1 commit into from
Sep 14, 2021
Merged

feat(api): add BOBA price feeds #58

merged 1 commit into from
Sep 14, 2021

Conversation

Tommytrg
Copy link
Member

@Tommytrg Tommytrg commented Aug 19, 2021 •
edited by aesedepece
Loading

Close #51

@aesedepece aesedepece linked an issue Aug 26, 2021 that may be closed by this pull request
Add Boba feeds #51
Closed
mariocao
mariocao reviewed Aug 31, 2021
View reviewed changes
Copy link
Contributor

@mariocao mariocao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR still up to date?

aesedepece
aesedepece requested changes Sep 2, 2021
View reviewed changes
packages/api/src/dataFeeds.json Outdated Show resolved Hide resolved
packages/api/src/dataFeeds.json Outdated Show resolved Hide resolved
packages/api/src/dataFeeds.json Outdated Show resolved Hide resolved
@Tommytrg Tommytrg force-pushed the boba-feeds branch 4 times, most recently from bffd20d to 89036b9 Compare September 9, 2021 10:05
@Tommytrg
Copy link
Member Author

Tommytrg commented Sep 9, 2021

Is this PR still up to date?

Indeed, I've updated and rebased the PR

aesedepece
aesedepece reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@aesedepece aesedepece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me but let's wait for the final addresses!

aesedepece
aesedepece requested changes Sep 9, 2021
View reviewed changes
packages/api/src/dataFeeds.json Outdated Show resolved Hide resolved
packages/api/src/dataFeeds.json Outdated Show resolved Hide resolved
@aesedepece aesedepece merged commit af36b2f into witnet:main Sep 14, 2021
@aesedepece
Copy link
Member

Merged in af36b2f

@Tommytrg Tommytrg deleted the boba-feeds branch July 16, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariocao mariocao mariocao left review comments

@aesedepece aesedepece aesedepece requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Boba feeds
3 participants
@Tommytrg @aesedepece @mariocao